Opened 7 years ago

Closed 3 years ago

Last modified 3 years ago

#9045 closed Bug (fixed)

PhoneNumberField listed in ModelForm docs as a Model field, but PhoneNumberField moved.

Reported by: ericvw Owned by: ericvw
Component: Forms Version: master
Severity: Normal Keywords: modelform
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In the documentation, http://docs.djangoproject.com/en/dev/topics/forms/modelforms/#field-types, PhoneNumberField is listed under the Model field type of which was removed from the Model documentation and causes confusion.

I propose to either:
1) Remove that entire row completely
2) Annotate that where it has moved to like the Form field type.

Attachments (1)

9045.diff (709 bytes) - added by ericholscher 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by ericvw

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 6 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:3 Changed 6 years ago by ericholscher

  • Triage Stage changed from Unreviewed to Accepted

I don't know the correct resolution, I'd say we should remove it since there are lots of phone number fields, and they are documented in the local flavor docs.

Changed 6 years ago by ericholscher

comment:4 Changed 4 years ago by lukeplant

  • Severity set to Normal
  • Type set to Bug

comment:5 Changed 3 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:6 Changed 3 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:7 Changed 3 years ago by Claude Paroz <claude@…>

  • Resolution set to fixed
  • Status changed from assigned to closed

In 8248d1402982041490b5d6bb45514ffdba0e18d3:

Removed US localflavor-specific tests from core

Also fixes #9045.

comment:8 Changed 3 years ago by Claude Paroz <claude@…>

In fce779475e221e322a25dbf30dc25003e831afc2:

[1.5.x] Removed US localflavor-specific tests from core

Also fixes #9045.
Backport of 8248d1402 from master.

Note: See TracTickets for help on using tickets.
Back to Top