Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#8963 closed (fixed)

Comments framework should use standard decorators where possible

Reported by: Jarek Zgoda Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Comments framework uses custom method for assuring proper HTTP method is used in view breaking DRY principle. Attached patch fixes this issuel

Attachments (1)

contrib-comments-requirepost.diff (1.1 KB) - added by Jarek Zgoda 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Jarek Zgoda

comment:1 Changed 8 years ago by Thejaswi Puthraya

Triage Stage: UnreviewedAccepted

Fantastic idea, I never even knew there was a decorator for this.

comment:2 Changed 8 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

(In [9121]) Fixed #8963 -- Use the require_POST decorator instead of doing things manually in one of the comment views. Thanks, zgoda.

comment:3 Changed 8 years ago by Malcolm Tredinnick

(In [9128]) [1.0.X] Fixed #8963 -- Use the require_POST decorator instead of doing things manually in one of the comment views. Thanks, zgoda.

Bakcport of r9121 from trunk.

comment:4 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top