Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#8963 closed (fixed)

Comments framework should use standard decorators where possible

Reported by: Jarek Zgoda Owned by: nobody
Component: contrib.comments Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Comments framework uses custom method for assuring proper HTTP method is used in view breaking DRY principle. Attached patch fixes this issuel

Attachments (1)

contrib-comments-requirepost.diff​ (1.1 KB ) - added by Jarek Zgoda 16 years ago.

Download all attachments as: .zip

Change History (5)

by Jarek Zgoda, 16 years ago

Attachment: contrib-comments-requirepost.diff​ added

comment:1 by Thejaswi Puthraya, 16 years ago

Triage Stage: Unreviewed → Accepted

Fantastic idea, I never even knew there was a decorator for this.

comment:2 by Malcolm Tredinnick, 16 years ago

Resolution: → fixed
Status: new → closed

(In [9121]) Fixed #8963 -- Use the require_POST decorator instead of doing things manually in one of the comment views. Thanks, zgoda.

comment:3 by Malcolm Tredinnick, 16 years ago

(In [9128]) [1.0.X] Fixed #8963 -- Use the require_POST decorator instead of doing things manually in one of the comment views. Thanks, zgoda.

Bakcport of r9121 from trunk.

comment:4 by (none), 16 years ago

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top