Opened 16 years ago
Closed 11 years ago
#8896 closed New feature (wontfix)
Routing according also to hostname
Reported by: | veena | Owned by: | jshedd |
---|---|---|---|
Component: | Core (URLs) | Version: | 1.0 |
Severity: | Normal | Keywords: | routing hostname |
Cc: | mike.huynh+django@…, jedie, Gert Van Gool, Florian Apolloner, cg@…, charette.s@… | Triage Stage: | Someday/Maybe |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
There should be a possibility to route urls even according to hostname.
It's quite often especially in blog sites that users get 3rd domain eg. http://username.example.com
In Django url router doesn't take hostname in consideration.
You can write own middleware, where you can rewrite username.example.com to something like example.com/user/username/ in process_request() function. But then function like "reverse()", decorator like "login" or template tag like "{% url %}" are not able to construct whole url with hostname back now.
In case of implementation routing with hostname there could be simple syntax in urls like that:
urlpatterns = ( ('^forum/$', forum) # normal route ('^/(username)\.example\.com/forum/$', user_forum) # route with domain with http protocol ('^//(username)\.example\.com/forum/$', user_forum) # or syntax with double slashes to have a more impact to visibility and parallel to http:// ('^s//(username)\.example\.com/forum/$', secure_user_forum) # route with domain with https protocol )
There should be some enhancement to decouple hostname from route. For example:
('^//(username)\.SETTINGS_DOMAIN_WILDCARDS\.[a-zA-Z]{2-4}/forum/$', user_forum)
Or using some special mark:
('^//(?P<username>)(?site)/forum/$', user_forum) # complete with domain from actual Site or RequestSite object ('^//(?P<username>)(?site=2)/forum/$', user_forum) # complete with domain with ID 2 from Site object
In reverse functions proper url with hostname should be considered.
I think there is need to more clarify all possible circumstances they can occure before implementing of this feature would be start. It could be nice feature in 1.1 version of Django.
Change History (18)
comment:1 by , 16 years ago
comment:2 by , 16 years ago
Triage Stage: | Unreviewed → Someday/Maybe |
---|
comment:4 by , 15 years ago
#5034 may address this issue in that reverse() and consequently {% url %} respect the overridden urlconf.
comment:5 by , 15 years ago
milestone: | → 1.2 |
---|---|
Owner: | changed from | to
comment:6 by , 15 years ago
milestone: | 1.2 |
---|
comment:7 by , 15 years ago
Cc: | added |
---|
comment:8 by , 15 years ago
Cc: | added |
---|
comment:9 by , 15 years ago
Cc: | added |
---|
comment:10 by , 14 years ago
Cc: | added |
---|
comment:11 by , 14 years ago
Severity: | → Normal |
---|---|
Type: | → New feature |
comment:12 by , 13 years ago
Cc: | added |
---|---|
Easy pickings: | unset |
comment:13 by , 13 years ago
You might want to have a look at the django-hosts app: http://pypi.python.org/pypi/django-hosts/
comment:15 by , 13 years ago
Cc: | added |
---|
comment:16 by , 12 years ago
Component: | Core (Other) → Core (URLs) |
---|
comment:18 by , 11 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
This has been solved by external apps and I'm happy with that solution.
Django should remain focused on the mainstream use cases.
This one isn't unheard of, but it's hardly common.
There should be (?P<username>) instead of (username) in first two examples.