Opened 20 years ago

Closed 20 years ago

Last modified 18 years ago

#889 closed defect (fixed)

[patch] `str()` should be used in admin interface popup-add

Reported by: Tom Tobin <korpios@…> Owned by: Adrian Holovaty
Component: contrib.admin Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

As per #710 and the corresponding changes to the new-admin branch (e.g., [1042]), str() should be used rather than repr() for the form value of newly popup-added foreign items. (Patch to follow.)

Attachments (2)

new-admin_popup_str_fix.patch​ (840 bytes ) - added by Tom Tobin <korpios@…> 20 years ago.
Fix against new-admin r1386 for issue in ticket.
trunk-admin_popup_str_fix.diff​ (840 bytes ) - added by Tom Tobin <korpios@…> 20 years ago.
make form value of popup-added foreign items based on str (against r2306 of trunk)

Download all attachments as: .zip

Change History (7)

by Tom Tobin <korpios@…>, 20 years ago

Attachment: new-admin_popup_str_fix.patch​ added

Fix against new-admin r1386 for issue in ticket.

comment:1 by rjwittams, 20 years ago

Owner: changed from rjwittams to Adrian Holovaty

this is now a trunk issue

comment:2 by rjwittams, 20 years ago

Summary: new-admin: `str()` should be used in admin interface popup-add → [patch] `str()` should be used in admin interface popup-add

by Tom Tobin <korpios@…>, 20 years ago

Attachment: trunk-admin_popup_str_fix.diff​ added

make form value of popup-added foreign items based on str (against r2306 of trunk)

comment:3 by Tom Tobin <korpios@…>, 20 years ago

As this just bit me again on a fresh trunk checkout, I thought I'd update the patch.

comment:4 by Jacob, 20 years ago

Resolution: → fixed
Status: new → closed

(In [2415]) Fixed #889 (Thanks, Tom Tobin)

comment:5 by korpios, 18 years ago

Reporter: changed from Tom Tobin <korpios@…> to Tom Tobin <korpios@…>
Note: See TracTickets for help on using tickets.
Back to Top