Code

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#889 closed defect (fixed)

[patch] `str()` should be used in admin interface popup-add

Reported by: Tom Tobin <korpios@…> Owned by: adrian
Component: contrib.admin Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

As per #710 and the corresponding changes to the new-admin branch (e.g., [1042]), str() should be used rather than repr() for the form value of newly popup-added foreign items. (Patch to follow.)

Attachments (2)

new-admin_popup_str_fix.patch (840 bytes) - added by Tom Tobin <korpios@…> 8 years ago.
Fix against new-admin r1386 for issue in ticket.
trunk-admin_popup_str_fix.diff (840 bytes) - added by Tom Tobin <korpios@…> 8 years ago.
make form value of popup-added foreign items based on str (against r2306 of trunk)

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Tom Tobin <korpios@…>

Fix against new-admin r1386 for issue in ticket.

comment:1 Changed 8 years ago by rjwittams

  • Owner changed from rjwittams to adrian

this is now a trunk issue

comment:2 Changed 8 years ago by rjwittams

  • Summary changed from new-admin: `str()` should be used in admin interface popup-add to [patch] `str()` should be used in admin interface popup-add

Changed 8 years ago by Tom Tobin <korpios@…>

make form value of popup-added foreign items based on str (against r2306 of trunk)

comment:3 Changed 8 years ago by Tom Tobin <korpios@…>

As this just bit me again on a fresh trunk checkout, I thought I'd update the patch.

comment:4 Changed 8 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [2415]) Fixed #889 (Thanks, Tom Tobin)

comment:5 Changed 7 years ago by korpios

  • Reporter changed from Tom Tobin <korpios@…> to Tom Tobin <korpios@…>

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.