Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#8879 closed (fixed)

ngettext is used in comments framework

Reported by: zgoda Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

There is one place where ngettext() is used to translate strings in comment framework code. Since Django is all-unicode inside, ungettext() should be used. Attached patch fixes this issue.

Attachments (1)

contrib-comments-ungettext.diff (1.1 KB) - added by zgoda 7 years ago.
Patch to replace call to ngettext() where ungettext() should be used

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by zgoda

Patch to replace call to ngettext() where ungettext() should be used

comment:1 Changed 7 years ago by jezdez

  • milestone post-1.0 deleted
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r9116.

comment:3 Changed 6 years ago by mtredinnick

(In [9123]) [1.0.X] Fixed #8879 -- Used ungettext instead of ngettext in the comments framework.
Patch from zgoda.

Backport of r9116 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top