Opened 17 years ago

Closed 17 years ago

Last modified 17 years ago

#8879 closed (fixed)

ngettext is used in comments framework

Reported by: Jarek Zgoda Owned by: nobody
Component: contrib.comments Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

There is one place where ngettext() is used to translate strings in comment framework code. Since Django is all-unicode inside, ungettext() should be used. Attached patch fixes this issue.

Attachments (1)

contrib-comments-ungettext.diff​ (1.1 KB ) - added by Jarek Zgoda 17 years ago.
Patch to replace call to ngettext() where ungettext() should be used

Download all attachments as: .zip

Change History (4)

by Jarek Zgoda, 17 years ago

Attachment: contrib-comments-ungettext.diff​ added

Patch to replace call to ngettext() where ungettext() should be used

comment:1 by Jannis Leidel, 17 years ago

milestone: post-1.0
Triage Stage: Unreviewed → Accepted

comment:2 by Malcolm Tredinnick, 17 years ago

Resolution: → fixed
Status: new → closed

Fixed in r9116.

comment:3 by Malcolm Tredinnick, 17 years ago

(In [9123]) [1.0.X] Fixed #8879 -- Used ungettext instead of ngettext in the comments framework.
Patch from zgoda.

Backport of r9116 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top