Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#8879 closed (fixed)

ngettext is used in comments framework

Reported by: Jarek Zgoda Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

There is one place where ngettext() is used to translate strings in comment framework code. Since Django is all-unicode inside, ungettext() should be used. Attached patch fixes this issue.

Attachments (1)

contrib-comments-ungettext.diff (1.1 KB) - added by Jarek Zgoda 8 years ago.
Patch to replace call to ngettext() where ungettext() should be used

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Jarek Zgoda

Patch to replace call to ngettext() where ungettext() should be used

comment:1 Changed 8 years ago by Jannis Leidel

milestone: post-1.0
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Triage Stage: UnreviewedAccepted

comment:2 Changed 8 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

Fixed in r9116.

comment:3 Changed 8 years ago by Malcolm Tredinnick

(In [9123]) [1.0.X] Fixed #8879 -- Used ungettext instead of ngettext in the comments framework.
Patch from zgoda.

Backport of r9116 from trunk.

Note: See TracTickets for help on using tickets.
Back to Top