Opened 10 years ago

Closed 9 years ago

Last modified 7 years ago

#8853 closed (fixed)

admindoc :template: role should not append .html

Reported by: Ben Spaulding Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords: admindocs
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no


Many other template suffixes are used besides .html, for example .txt, .js, .xml, etc. If developers want to document those templates in their docstrings they are out of luck because Django currently appends .html to the filename that is passed into the view. The attached patch will fix the problem, but it is backwards incompatible.

Attachments (1)

admindoc-template-role.diff (608 bytes) - added by Ben Spaulding 10 years ago.

Download all attachments as: .zip

Change History (8)

Changed 10 years ago by Ben Spaulding

Attachment: admindoc-template-role.diff added

comment:1 Changed 10 years ago by Malcolm Tredinnick

milestone: 1.0

We can deal with this after 1.0. We're not guaranteeing that documentation will never change (even documentation generated from comments).

comment:2 Changed 9 years ago by Jacob

milestone: 1.1
Resolution: fixed
Status: newclosed
Triage Stage: UnreviewedAccepted

comment:3 Changed 9 years ago by Jacob

Resolution: fixed
Status: closedreopened

Oops, didn't mean to fix.

comment:4 Changed 9 years ago by Russell Keith-Magee

Component: Uncategorizeddjango.contrib.admin

comment:5 Changed 9 years ago by Eric Holscher

Triage Stage: AcceptedReady for checkin

comment:6 Changed 9 years ago by Jacob

Resolution: fixed
Status: reopenedclosed

(In [10315]) Fixed #8853: don't automatically append .html in the admindoc :template: role. Thanks, Ben Spaulding.

comment:7 Changed 7 years ago by Jacob

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top