Opened 7 years ago

Closed 6 years ago

Last modified 3 years ago

#8853 closed (fixed)

admindoc :template: role should not append .html

Reported by: benspaulding Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords: admindocs
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Many other template suffixes are used besides .html, for example .txt, .js, .xml, etc. If developers want to document those templates in their docstrings they are out of luck because Django currently appends .html to the filename that is passed into the view. The attached patch will fix the problem, but it is backwards incompatible.

Attachments (1)

admindoc-template-role.diff (608 bytes) - added by benspaulding 7 years ago.

Download all attachments as: .zip

Change History (8)

Changed 7 years ago by benspaulding

comment:1 Changed 7 years ago by mtredinnick

  • milestone 1.0 deleted
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

We can deal with this after 1.0. We're not guaranteeing that documentation will never change (even documentation generated from comments).

comment:2 Changed 6 years ago by jacob

  • milestone set to 1.1
  • Resolution set to fixed
  • Status changed from new to closed
  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 6 years ago by jacob

  • Resolution fixed deleted
  • Status changed from closed to reopened

Oops, didn't mean to fix.

comment:4 Changed 6 years ago by russellm

  • Component changed from Uncategorized to django.contrib.admin

comment:5 Changed 6 years ago by ericholscher

  • Triage Stage changed from Accepted to Ready for checkin

comment:6 Changed 6 years ago by jacob

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [10315]) Fixed #8853: don't automatically append .html in the admindoc :template: role. Thanks, Ben Spaulding.

comment:7 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top