Opened 16 years ago

Closed 15 years ago

Last modified 13 years ago

#8853 closed (fixed)

admindoc :template: role should not append .html

Reported by: Ben Spaulding Owned by: nobody
Component: contrib.admin Version: dev
Severity: Keywords: admindocs
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Many other template suffixes are used besides .html, for example .txt, .js, .xml, etc. If developers want to document those templates in their docstrings they are out of luck because Django currently appends .html to the filename that is passed into the view. The attached patch will fix the problem, but it is backwards incompatible.

Attachments (1)

admindoc-template-role.diff​ (608 bytes ) - added by Ben Spaulding 16 years ago.

Download all attachments as: .zip

Change History (8)

by Ben Spaulding, 16 years ago

Attachment: admindoc-template-role.diff​ added

comment:1 by Malcolm Tredinnick, 16 years ago

milestone: 1.0

We can deal with this after 1.0. We're not guaranteeing that documentation will never change (even documentation generated from comments).

comment:2 by Jacob, 15 years ago

milestone: → 1.1
Resolution: → fixed
Status: new → closed
Triage Stage: Unreviewed → Accepted

comment:3 by Jacob, 15 years ago

Resolution: fixed
Status: closed → reopened

Oops, didn't mean to fix.

comment:4 by Russell Keith-Magee, 15 years ago

Component: Uncategorized → django.contrib.admin

comment:5 by Eric Holscher, 15 years ago

Triage Stage: Accepted → Ready for checkin

comment:6 by Jacob, 15 years ago

Resolution: → fixed
Status: reopened → closed

(In [10315]) Fixed #8853: don't automatically append .html in the admindoc :template: role. Thanks, Ben Spaulding.

comment:7 by Jacob, 13 years ago

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top