Code

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#8803 closed (fixed)

Possibility to use username if full name is missing in the comments framework

Reported by: thejaswi_puthraya Owned by: nobody
Component: contrib.comments Version: master
Severity: Keywords: fullname, username, comments
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The ticket summary mentions it all. After a discussion with Jacob on IRC, it was decided to have this though having the full name is always recommended.

Attachments (2)

8803.diff (719 bytes) - added by thejaswi_puthraya 6 years ago.
git-patch of the latest checkout
comments-view.diff (597 bytes) - added by benspaulding 6 years ago.
A little shorter version.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by thejaswi_puthraya

git-patch of the latest checkout

comment:1 Changed 6 years ago by benspaulding

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

I ran into the same issue and found this ticket. Just to reiterate, the view should use the get_full_name() or username because that’s what the model itself does. It just makes sense.

I have attached my patch just because I already had it made and it’s a little shorter. (I don’t care what color the bike shed it is, really.)

Changed 6 years ago by benspaulding

A little shorter version.

comment:2 Changed 6 years ago by mtredinnick

*sigh* You both should be smacked for not providing a test for the fix. :-(

Fortunately, I also stumbled across this and have a local patch with tests that I'll commit shortly.

comment:3 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [9118]) Fixed #8803 -- Allow authenticated users without first_name/last_name values set to post comments.

comment:4 Changed 6 years ago by mtredinnick

(In [9125]) [1.0.x] Fixed #8803 -- Allow authenticated users without first_name/last_name values set to post comments.

Backport of r9118 from trunk.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.