Opened 10 years ago

Closed 10 years ago

#8800 closed (fixed)

New docs search producing invalid HTML

Reported by: Fraser Nevett Owned by: Jacob
Component: *.djangoproject.com Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Very minor, but I noticed that my patch from #8723 that was committed in [8844] contains errors which causes the new docs site to produce invalid HTML.

The script tag in search_form.html has an unescaped ampersand (this was actually copied and pasted from Google's example code).

Also, it looks like the lang variable is never populated.

The attached (untested) patch should hopefully fix both of these.

Attachments (1)

8800.patch (1.5 KB) - added by Fraser Nevett 10 years ago.

Download all attachments as: .zip

Change History (4)

Changed 10 years ago by Fraser Nevett

Attachment: 8800.patch added

comment:1 Changed 10 years ago by Ivan Giuliani

Has patch: set

comment:2 Changed 10 years ago by Malcolm Tredinnick

Component: DocumentationDjango Web site

comment:3 Changed 10 years ago by Gary Wilson

Resolution: fixed
Status: newclosed

seems this was fixed in [9073].

Note: See TracTickets for help on using tickets.
Back to Top