Code

Opened 6 years ago

Closed 5 years ago

#8800 closed (fixed)

New docs search producing invalid HTML

Reported by: frasern Owned by: jacob
Component: *.djangoproject.com Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Very minor, but I noticed that my patch from #8723 that was committed in [8844] contains errors which causes the new docs site to produce invalid HTML.

The script tag in search_form.html has an unescaped ampersand (this was actually copied and pasted from Google's example code).

Also, it looks like the lang variable is never populated.

The attached (untested) patch should hopefully fix both of these.

Attachments (1)

8800.patch (1.5 KB) - added by frasern 6 years ago.

Download all attachments as: .zip

Change History (4)

Changed 6 years ago by frasern

comment:1 Changed 6 years ago by kratorius

  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 6 years ago by mtredinnick

  • Component changed from Documentation to Django Web site

comment:3 Changed 5 years ago by gwilson

  • Resolution set to fixed
  • Status changed from new to closed

seems this was fixed in [9073].

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.