Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#8788 closed (fixed)

correction for some typos in #8805

Reported by: Matthew Flanagan <mattimustang@…> Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

Index: django/forms/models.py
===================================================================
--- django/forms/models.py      (revision 8831)
+++ django/forms/models.py      (working copy)
@@ -244,7 +244,7 @@
             if self.instance.pk is not None:
                 qs = qs.exclude(pk=self.instance.pk)

-            # This cute trick with extra/values is the most efficiant way to
+            # This cute trick with extra/values is the most efficient way to
             # tell if a particular query returns any results.
             if qs.extra(select={'a': 1}).values('a').order_by():
                 model_name = capfirst(self.instance._meta.verbose_name)
Index: docs/topics/forms/modelforms.txt
===================================================================
--- docs/topics/forms/modelforms.txt    (revision 8831)
+++ docs/topics/forms/modelforms.txt    (working copy)
@@ -337,10 +337,10 @@
 Overriding the clean() method
 -----------------------------

-You can overide the ``clean()`` method on a model form to provide additional
+You can override the ``clean()`` method on a model form to provide additional
 validation in the same way you can on a normal form.  However, by default the
 ``clean()`` method validates the uniqueness of fields that are marked as unique
-on the model, and those marked as unque_together, if you would like to overide
+on the model, and those marked as unique_together, if you would like to override
 the ``clean()`` method and maintain the default validation you must call the
 parent class's ``clean()`` method.

Attachments (2)

typos.diff (1.6 KB) - added by Matthew Flanagan <mattimustang@…> 7 years ago.
"proper" patch
8788-2.diff (2.3 KB) - added by mir 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by jacob

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Can you please attach a real patch instead of pasting it into the description?

Changed 7 years ago by Matthew Flanagan <mattimustang@…>

"proper" patch

comment:2 Changed 7 years ago by mir

  • Component changed from Forms to Documentation
  • milestone set to 1.0
  • Triage Stage changed from Unreviewed to Ready for checkin

There are additional typos in the docs and a paragraph that needs to be broken into two. I'm attaching an improved patch.

Changed 7 years ago by mir

comment:3 Changed 7 years ago by mir

Can someone check the commas, please? I've never really figured out the English comma rules.

comment:4 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [8872]) Fixed #8788: fixed a few typoes in [8805]. Thanks, Matthew Flanagan and mir.

comment:5 Changed 7 years ago by jacob

mir: perfect use of the commas; well done :)

comment:6 Changed 4 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top