Opened 8 years ago

Last modified 17 months ago

#8760 new Cleanup/optimization

forms.ModelMultipleChoiceField should use "invalid_list" as error message key

Reported by: durdinator Owned by: nobody
Component: Forms Version: master
Severity: Normal Keywords: forms
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

The MultipleChoiceField uses "invalid_list", but ModelMultipleChoiceField uses "list" as the key for the similar error message.

Attachments (1)

8760.diff (2.8 KB) - added by Tim Graham 18 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by Jacob

milestone: 1.0post-1.0

It's a slight inconsistency, sure, but they are two different fields, so different error message keys are reasonable. Pushing post-1.0.

comment:2 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:3 Changed 8 years ago by Jacob

Triage Stage: UnreviewedAccepted

comment:4 Changed 6 years ago by Luke Plant

Severity: Normal
Type: Cleanup/optimization

comment:5 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:6 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:7 Changed 18 months ago by Markus Amalthea Magnuson

Should this change happen? The comments are ambiguous :)

comment:8 Changed 18 months ago by Tim Graham

Has patch: set

The implementation isn't difficult (see attached patch). The question is whether or not we accept this as a backwards incompatible change (to be documented if so) or try for some deprecation path. I'm not sure how a deprecation would work.

Changed 18 months ago by Tim Graham

Attachment: 8760.diff added

comment:9 Changed 17 months ago by Tim Graham

Patch needs improvement: set
Note: See TracTickets for help on using tickets.
Back to Top