Opened 8 years ago

Last modified 14 months ago

#8760 new Cleanup/optimization

forms.ModelMultipleChoiceField should use "invalid_list" as error message key

Reported by: durdinator Owned by: nobody
Component: Forms Version: master
Severity: Normal Keywords: forms
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no


The MultipleChoiceField uses "invalid_list", but ModelMultipleChoiceField uses "list" as the key for the similar error message.

Attachments (1)

8760.diff (2.8 KB) - added by timgraham 15 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 8 years ago by jacob

  • milestone changed from 1.0 to post-1.0
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

It's a slight inconsistency, sure, but they are two different fields, so different error message keys are reasonable. Pushing post-1.0.

comment:2 Changed 7 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:3 Changed 7 years ago by jacob

  • Triage Stage changed from Unreviewed to Accepted

comment:4 Changed 5 years ago by lukeplant

  • Severity set to Normal
  • Type set to Cleanup/optimization

comment:5 Changed 5 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:6 Changed 5 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:7 Changed 15 months ago by giuliettamasina

Should this change happen? The comments are ambiguous :)

comment:8 Changed 15 months ago by timgraham

  • Has patch set

The implementation isn't difficult (see attached patch). The question is whether or not we accept this as a backwards incompatible change (to be documented if so) or try for some deprecation path. I'm not sure how a deprecation would work.

Changed 15 months ago by timgraham

comment:9 Changed 14 months ago by timgraham

  • Patch needs improvement set
Note: See TracTickets for help on using tickets.
Back to Top