Opened 16 years ago

Closed 16 years ago

Last modified 12 years ago

#8705 closed (fixed)

Indentation problem in topics/db/models.txt

Reported by: Horst Gutmann <zerok@…> Owned by: nobody
Component: Documentation Version: dev
Severity: Keywords: rst, indentation
Cc: zerok@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The definition list of field options is rendered as blockquotes (and nested blockquotes). Fixed in attached patch.

Attachments (3)

indentation_modelstxt.diff (2.6 KB ) - added by Horst Gutmann <zerok@…> 16 years ago.
t8705.png (118.3 KB ) - added by Ramiro Morales 16 years ago.
t8705_r8767.diff (2.0 KB ) - added by Ramiro Morales 16 years ago.
New version of the patch with unneeded trailing spaces removed

Download all attachments as: .zip

Change History (10)

by Horst Gutmann <zerok@…>, 16 years ago

Attachment: indentation_modelstxt.diff added

comment:1 by Richard Barran, 16 years ago

milestone: 1.0
Triage Stage: UnreviewedAccepted

Tried out the patch, works as intended and fixes the incorrect rendering in the documentation.

To the original submitter: in future, can you submit patches in svn diff format rather than using the diff output from another Version Control tool? It will then conform to the Django patch guidelines and make life a lot easier for people (like myself) who are using the standard tools :-)

comment:2 by Jacob, 16 years ago

richardb: git diff format is common enough these days that we accept it. I'll update the guidelines when I get a chance.

comment:3 by Ramiro Morales, 16 years ago

Note to reviewers: The OP is describing the rendering in a local copy generated by make html as can be seen in the attached snapshot (Firefox 3, but it also happens with Safari 3.1.2, Konqueror 3.5 and IE7)

When I submitted #8693/[8737] (that took the opposite approach) it was guided by what I was seeing in the copy at http://docs.djangoproject.com/ so it seems the style sheets are different. This would also mean the rendering at the documentation website should be checked if/when this patch is committed.

by Ramiro Morales, 16 years ago

Attachment: t8705.png added

by Ramiro Morales, 16 years ago

Attachment: t8705_r8767.diff added

New version of the patch with unneeded trailing spaces removed

comment:4 by James Bennett, 16 years ago

Resolution: fixed
Status: newclosed

(In [8788]) Fixed #8705: Corrected some formatting issues in models documentation

in reply to:  2 ; comment:5 by Richard Barran, 16 years ago

Replying to jacob:

richardb: git diff format is common enough these days that we accept it. I'll update the guidelines when I get a chance.

Jacob: Ok, noted.

Horst Gutmann: apologies for criticizing your patch when it was, in fact, up to expected standards :-)

in reply to:  5 comment:6 by Horst Gutmann <zerok@…>, 16 years ago

Replying to richardb:

Replying to jacob:

richardb: git diff format is common enough these days that we accept it. I'll update the guidelines when I get a chance.

Jacob: Ok, noted.

Horst Gutmann: apologies for criticizing your patch when it was, in fact, up to expected standards :-)

Richard: No stress :-) I actually totally missed that passage in the guidelines until today ;-)

comment:7 by Jacob, 12 years ago

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top