#8683 closed (fixed)
NameError caused by typo in DateQuerySet._setup_query
| Reported by: | vung | Owned by: | Malcolm Tredinnick |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Accepted | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In !DateQuerySet._setup_query there is an assert whose second expression refers to a non-existent name ("field_name"). I modified it to be "field.name"
Attachments (2)
Change History (5)
by , 16 years ago
| Attachment: | DateQuerySet-assertion.diff added |
|---|
by , 16 years ago
| Attachment: | DateQuerySet-assertion-test.diff added |
|---|
comment:1 by , 16 years ago
| milestone: | → 1.0 |
|---|---|
| Owner: | changed from to |
| Status: | new → assigned |
| Triage Stage: | Unreviewed → Accepted |
Good catch. Thanks. I missed that in a recent refactor (and a test would have caught it, so that's important).
comment:2 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
I'm forgetting to put ticket numbers in the commit messages, today. :-(
Fixed in [8724].
Note:
See TracTickets
for help on using tickets.
Not sure this is worth a test, but just in case.