Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8683 closed (fixed)

NameError caused by typo in DateQuerySet._setup_query

Reported by: vung Owned by: Malcolm Tredinnick
Component: Database layer (models, ORM) Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In !DateQuerySet._setup_query there is an assert whose second expression refers to a non-existent name ("field_name"). I modified it to be "field.name"

Attachments (2)

DateQuerySet-assertion.diff (621 bytes) - added by vung 8 years ago.
DateQuerySet-assertion-test.diff (812 bytes) - added by vung 8 years ago.
Not sure this is worth a test, but just in case.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by vung

Attachment: DateQuerySet-assertion.diff added

Changed 8 years ago by vung

Not sure this is worth a test, but just in case.

comment:1 Changed 8 years ago by Malcolm Tredinnick

milestone: 1.0
Owner: changed from nobody to Malcolm Tredinnick
Status: newassigned
Triage Stage: UnreviewedAccepted

Good catch. Thanks. I missed that in a recent refactor (and a test would have caught it, so that's important).

comment:2 Changed 8 years ago by Malcolm Tredinnick

Resolution: fixed
Status: assignedclosed

I'm forgetting to put ticket numbers in the commit messages, today. :-(

Fixed in [8724].

comment:3 Changed 5 years ago by Jacob

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top