Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#8673 closed (fixed)

Missing import in django.core.files.move

Reported by: vung Owned by: nobody
Component: File uploads/storage Version: dev
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In [8493] the copied copystat in django.core.files.move uses stat.S_IMODE, but stat is not imported.

Attachments (2)

copystat-missing-import.diff (716 bytes ) - added by vung 16 years ago.
copystat-missing-import-2.diff (536 bytes ) - added by vung 16 years ago.
Moved the import in the exception handling block as suggested by julien

Download all attachments as: .zip

Change History (5)

by vung, 16 years ago

comment:1 by Julien Phalip, 16 years ago

Triage Stage: UnreviewedAccepted

Just a small suggestion, maybe the import should be under the ImportError block:

try:
    from shutil import copystat
except ImportError:
    import stat
    ...

by vung, 16 years ago

Moved the import in the exception handling block as suggested by julien

comment:2 by Jacob, 16 years ago

Resolution: fixed
Status: newclosed

(In [8720]) Fixed #8673: fixed a missing import in django.core.files.move.

comment:3 by Jacob, 13 years ago

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top