Code

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#8660 closed (fixed)

Calling User.get_profile() should pre-populate the user foreign key on the profile object

Reported by: mmalone Owned by: nobody
Component: contrib.auth Version: master
Severity: Keywords: cache profile user auth
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description (last modified by mtredinnick)

When you use the User.get_profile() method to fetch a profile object, it doesn't pre-populate profile's user attribute. This results in unnecessary DB queries when you go from User -> UserProfile and then later go from UserProfile -> User. This is actually a fairly common use case because people tend to attach methods that "extend" the user object in UserProfile, since they can't directly extend User.

For example, if you create a full_name() method on UserProfile that returns '%s %s' % (self.user.first_name, self.user.last_name), then in your templates, you do {{ User.get_profile.full_name }} , you end up doing two DB queries when only one in necessary.

The solution seems simple enough since the profile's User object must be called user. In django/contrib/auth/models.py a one liner after fetching the profile should do the trick:

  self._profile_cache = model._default_manager.get(user__id__exact=self.id)
+ self._profile_cache.user = self

Attachments (0)

Change History (5)

comment:1 Changed 6 years ago by mtredinnick

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

(The reason this isn't a real patch is because mmalone was working off a non-trunk checkout for his commercial stuff. So I asked him just to file the right line and we can turn it into a trivial patch later. Just noting so nobody wonders why he's being a bad patch writer.)

comment:2 Changed 6 years ago by mtredinnick

  • Description modified (diff)

comment:3 Changed 6 years ago by mtredinnick

Fixed in r9152.

comment:4 Changed 6 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 5 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.