Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#8660 closed (fixed)

Calling User.get_profile() should pre-populate the user foreign key on the profile object

Reported by: Michael Malone Owned by: nobody
Component: contrib.auth Version: master
Severity: Keywords: cache profile user auth
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Malcolm Tredinnick)

When you use the User.get_profile() method to fetch a profile object, it doesn't pre-populate profile's user attribute. This results in unnecessary DB queries when you go from User -> UserProfile and then later go from UserProfile -> User. This is actually a fairly common use case because people tend to attach methods that "extend" the user object in UserProfile, since they can't directly extend User.

For example, if you create a full_name() method on UserProfile that returns '%s %s' % (self.user.first_name, self.user.last_name), then in your templates, you do {{ User.get_profile.full_name }} , you end up doing two DB queries when only one in necessary.

The solution seems simple enough since the profile's User object must be called user. In django/contrib/auth/ a one liner after fetching the profile should do the trick:

  self._profile_cache = model._default_manager.get(
+ self._profile_cache.user = self

Change History (5)

comment:1 Changed 11 years ago by Malcolm Tredinnick

Triage Stage: UnreviewedAccepted

(The reason this isn't a real patch is because mmalone was working off a non-trunk checkout for his commercial stuff. So I asked him just to file the right line and we can turn it into a trivial patch later. Just noting so nobody wonders why he's being a bad patch writer.)

comment:2 Changed 11 years ago by Malcolm Tredinnick

Description: modified (diff)

comment:3 Changed 11 years ago by Malcolm Tredinnick

Fixed in r9152.

comment:4 Changed 11 years ago by Malcolm Tredinnick

Resolution: fixed
Status: newclosed

comment:5 Changed 10 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top