Opened 16 years ago

Closed 13 years ago

#8658 closed Bug (wontfix)

Per request environment not cleaned between requests with mod_python

Reported by: André Cruz Owned by: nobody
Component: Core (Other) Version: 1.0-beta
Severity: Normal Keywords: modpython environment
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

I'm using a single sign-on system called Shibboleth which is implemented via an Apache module that populates the request environment with information about the logged-in user (if there is one) to the underlying application, Django in this case.

What I'm seeing is, when a logged-in user appears, the vars are set and I can access them in the views with os.environ[VAR]. After that, all requests remain with those vars set, even if the Shibboleth module does not set them in the request environment.

I think this is because of this line in the modpython handler:

  os.environ.update(req.subprocess_env)

This adds the vars to the environ but does not clear them if they are not there. Maybe a copy of the original environment should be kept and restored after the request is served. Or is there a way to access the req.subprocess_env in a view?

Change History (5)

comment:1 by Jacob, 16 years ago

milestone: 1.0
Triage Stage: UnreviewedDesign decision needed

comment:2 by James Bennett, 16 years ago

Resolution: fixed
Status: newclosed

(In [8755]) Fixed #8658: Added cross-references to signals docs from Model.save() docs

comment:3 by James Bennett, 16 years ago

Resolution: fixed
Status: closedreopened

(wrong ticket number in commit message)

comment:4 by Luke Plant, 13 years ago

Severity: Normal
Type: Bug

comment:5 by Jacob, 13 years ago

Easy pickings: unset
Resolution: wontfix
Status: reopenedclosed
UI/UX: unset

mod_python has been deprecated and will be removed shortly so we're no longer fixing bugs related to mod_python. Switch to mod_wsgi (or another WSGI container) and all your prayers will be answered!

Note: See TracTickets for help on using tickets.
Back to Top