Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#8651 closed (fixed)

Deserializer does not allow for 0 based primary keys on a foreign keyed table

Reported by: chesnutd Owned by: jacob
Component: Uncategorized Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The deserializer in core/serializers/python does not take into account that you can have a foreign key values of zero. The statement:

if field_value:

It should be changed to

if field_value is not None:

I've included that patch

Attachments (1)

core_seralizers_python_patch.diff (543 bytes) - added by chesnutd 7 years ago.
deserializer patch

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by chesnutd

deserializer patch

comment:1 Changed 7 years ago by mtredinnick

  • milestone set to 1.0
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 7 years ago by jacob

  • Owner changed from nobody to jacob
  • Status changed from new to assigned
  • Triage Stage changed from Accepted to Ready for checkin

comment:3 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [8676].

comment:4 Changed 4 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top