#8643 closed (fixed)
Misleading comments in django.http.multipartparser.py
| Reported by: | KayEss | Owned by: | Gary Wilson |
|---|---|---|---|
| Component: | HTTP handling | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
There are a number of comments in the file presumably left over from before the refactoring work. The patch simply removes some and rewords a few others.
- The input data is not a bytestring, it's a file. See my web site for a StringIO example.
- file_upload_dir isn't mentioned anywhere apart from in the comment. I guess that the upload handlers are now meant to deal with this.
The upload parser does also seem to be missing some error handling. It doesn't appear to check that it has parsed the same number of bytes as the specified content length and it certainly doesn't throw any sort of error if the input data is empty.
The patch is against r8047.
Attachments (1)
Change History (8)
by , 16 years ago
comment:1 by , 16 years ago
| Component: | Uncategorized → HTTP handling |
|---|
comment:2 by , 16 years ago
| milestone: | → 1.1 |
|---|---|
| Triage Stage: | Unreviewed → Ready for checkin |
comment:3 by , 16 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:5 by , 16 years ago
comment:6 by , 16 years ago
In the future, please provide patches from the root of trunk. This makes things easier for committers, as they don't have to go hunting through the tree for the file to patch. Thanks.
Note:
See TracTickets
for help on using tickets.
Comments patch