Code

Opened 6 years ago

Closed 5 years ago

Last modified 3 years ago

#8643 closed (fixed)

Misleading comments in django.http.multipartparser.py

Reported by: KayEss Owned by: gwilson
Component: HTTP handling Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

There are a number of comments in the file presumably left over from before the refactoring work. The patch simply removes some and rewords a few others.

  • file_upload_dir isn't mentioned anywhere apart from in the comment. I guess that the upload handlers are now meant to deal with this.

The upload parser does also seem to be missing some error handling. It doesn't appear to check that it has parsed the same number of bytes as the specified content length and it certainly doesn't throw any sort of error if the input data is empty.

The patch is against r8047.

Attachments (1)

mp.patch (906 bytes) - added by KayEss 6 years ago.
Comments patch

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by KayEss

Comments patch

comment:1 Changed 6 years ago by Piotr Lewandowski <django@…>

  • Component changed from Uncategorized to HTTP handling
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 5 years ago by jacob

  • milestone set to 1.1
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:3 Changed 5 years ago by gwilson

  • Owner changed from nobody to gwilson
  • Status changed from new to assigned

comment:4 Changed 5 years ago by gwilson

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [10213]) Fixed #8643 -- Corrected docstrings of MultiPartParser, thanks KayEss.

comment:5 Changed 5 years ago by gwilson

(In [10214]) [1.0.X]: Fixed #8643 -- Corrected docstrings of MultiPartParser, thanks KayEss.

Backport of r10213 from trunk.

comment:6 Changed 5 years ago by gwilson

In the future, please provide patches from the root of trunk. This makes things easier for committers, as they don't have to go hunting through the tree for the file to patch. Thanks.

comment:7 Changed 3 years ago by jacob

  • milestone 1.1 deleted

Milestone 1.1 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.