Opened 8 years ago

Closed 8 years ago

#8623 closed (wontfix)

New comments upgrade guide breaks permalinks, views

Reported by: Ben Spaulding Owned by: nobody
Component: contrib.comments Version:
Severity: Keywords: sql, comments, docs
Cc: Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The SQL provided by the comment upgrade guide does not preserve a comment’s id and therefore breaks most permalinks and any detail view that uses the id to resolve the url.

Neither of these cases are absolutely critical because:

  1. permalinks using <url>/#<comment_id> still get you to the page, just not the comment,
  2. almost no one (I would guess) uses a comment detail view.

Further, if someone was using both comments and free comments it will not be possible to preserve the id’s for both as they are being merged in to one table. But they could choose which one to preserve and do that one first.

Unfortunately my SQL-fu is not good enough to write a patch, or even know if preserving the comment’s id is possible.

Change History (3)

comment:1 Changed 8 years ago by Thejaswi Puthraya

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

This can be done but are specialized cases. Will leave it for Jacob to decide.

comment:2 Changed 8 years ago by Thejaswi Puthraya

Component: Documentationdjango.contrib.comments
Triage Stage: UnreviewedDesign decision needed

Will leave it for core-devs to decide.

comment:3 Changed 8 years ago by Adrian Holovaty

Resolution: wontfix
Status: newclosed

Given that the old comments system was never documented, I think it's OK that comment IDs change in this upgrade guide.

Note: See TracTickets for help on using tickets.
Back to Top