Code

Opened 8 years ago

Closed 8 years ago

#861 closed defect (fixed)

Warn on single-letter field names in unique_together

Reported by: garthk Owned by: adrian
Component: contrib.admin Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

If a user puts a single pair of field names in unique_together, they'll get something looking like this traceback when they try to install the application:

Traceback (most recent call last):
  File "C:\dev\django-svn\django\core\management.py", line 389, in install
    sql_list = get_sql_all(mod)
  File "C:\dev\django-svn\django\core\management.py", line 261, in get_sql_all
    return get_sql_create(mod) + get_sql_initial_data(mod)
  File "C:\dev\django-svn\django\core\management.py", line 88, in get_sql_create
    table_output.append('UNIQUE (%s)' % \
  File "C:\dev\django-svn\django\core\meta\__init__.py", line 393, in get_field
    raise FieldDoesNotExist, "name=%s" % name
django.core.meta.FieldDoesNotExist: name=f

The user might waste a lot of time figuring out that the reason for this is that they specified ('field1', 'field2') or (('field1', 'field2')) rather than (('field1', 'field2'),) or [('field1', 'field2')].

Attachments (1)

861.diff (1.0 KB) - added by garthk 8 years ago.
Patch with descriptive error

Download all attachments as: .zip

Change History (2)

Changed 8 years ago by garthk

Patch with descriptive error

comment:1 Changed 8 years ago by adrian

  • Resolution set to fixed
  • Status changed from new to closed

(In [1323]) Fixed #861 -- Model validator now validates unique_together

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.