Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#8583 closed (fixed)

Comments upgrade SQL fails on FreeComment data

Reported by: rajeshd Owned by: jacob
Component: Documentation Version: master
Severity: Keywords: comments docs
Cc: rajesh.dhawan@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


In the contrib.comments upgrade instructions, the UPDATE statements work when migrating the old Comment data but they fail on FreeComment data because the latter has null user_ids.

Attached patch ensures that the UPDATES get applied only to migrated Comment data (i.e. when user_id is not NULL.) Not sure if this is good enough but it works for me in PGSQL.

Attachments (1)

comments_upgrade_sql.diff (663 bytes) - added by rajeshd 6 years ago.
Comments upgrade SQL

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by rajeshd

Comments upgrade SQL

comment:1 Changed 6 years ago by rajeshd

  • Cc dsalvetti@…, philipp@… removed
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Sorry...I accidentally CC'ed other email addresses -- darn browser saved forms!

comment:2 Changed 6 years ago by thejaswi_puthraya

  • Triage Stage changed from Unreviewed to Accepted

What you've reported happens only with Postgresql. But anyways, it has to corrected. Thanks for the patch.

comment:3 Changed 6 years ago by jacob

  • Owner changed from nobody to jacob
  • Status changed from new to assigned
  • Triage Stage changed from Accepted to Ready for checkin

comment:4 Changed 6 years ago by jacob

  • Component changed from django.contrib.comments to Documentation

comment:5 Changed 6 years ago by russellm

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8653]) Fixed #8583: Modified the migration SQL described in the comments upgrade docs to account for a problem found with freecomments using Postgres. Thanks to rajeshd for the report.

comment:6 Changed 3 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'

E-mail address and user name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.