#8583 closed (fixed)
Comments upgrade SQL fails on FreeComment data
| Reported by: | Rajesh Dhawan | Owned by: | Jacob |
|---|---|---|---|
| Component: | Documentation | Version: | dev |
| Severity: | Keywords: | comments docs | |
| Cc: | rajesh.dhawan@… | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
In the contrib.comments upgrade instructions, the UPDATE statements work when migrating the old Comment data but they fail on FreeComment data because the latter has null user_ids.
Attached patch ensures that the UPDATES get applied only to migrated Comment data (i.e. when user_id is not NULL.) Not sure if this is good enough but it works for me in PGSQL.
Attachments (1)
Change History (7)
by , 17 years ago
| Attachment: | comments_upgrade_sql.diff added |
|---|
comment:1 by , 17 years ago
| Cc: | removed |
|---|
Sorry...I accidentally CC'ed other email addresses -- darn browser saved forms!
comment:2 by , 17 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
What you've reported happens only with Postgresql. But anyways, it has to corrected. Thanks for the patch.
comment:3 by , 17 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
| Triage Stage: | Accepted → Ready for checkin |
comment:4 by , 17 years ago
| Component: | django.contrib.comments → Documentation |
|---|
comment:5 by , 17 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note:
See TracTickets
for help on using tickets.
Comments upgrade SQL