Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8583 closed (fixed)

Comments upgrade SQL fails on FreeComment data

Reported by: Rajesh Dhawan Owned by: Jacob
Component: Documentation Version: master
Severity: Keywords: comments docs
Cc: rajesh.dhawan@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In the contrib.comments upgrade instructions, the UPDATE statements work when migrating the old Comment data but they fail on FreeComment data because the latter has null user_ids.

Attached patch ensures that the UPDATES get applied only to migrated Comment data (i.e. when user_id is not NULL.) Not sure if this is good enough but it works for me in PGSQL.

Attachments (1)

comments_upgrade_sql.diff (663 bytes) - added by Rajesh Dhawan 8 years ago.
Comments upgrade SQL

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by Rajesh Dhawan

Attachment: comments_upgrade_sql.diff added

Comments upgrade SQL

comment:1 Changed 8 years ago by Rajesh Dhawan

Cc: dsalvetti@… philipp@… removed

Sorry...I accidentally CC'ed other email addresses -- darn browser saved forms!

comment:2 Changed 8 years ago by Thejaswi Puthraya

Triage Stage: UnreviewedAccepted

What you've reported happens only with Postgresql. But anyways, it has to corrected. Thanks for the patch.

comment:3 Changed 8 years ago by Jacob

Owner: changed from nobody to Jacob
Status: newassigned
Triage Stage: AcceptedReady for checkin

comment:4 Changed 8 years ago by Jacob

Component: django.contrib.commentsDocumentation

comment:5 Changed 8 years ago by Russell Keith-Magee

Resolution: fixed
Status: assignedclosed

(In [8653]) Fixed #8583: Modified the migration SQL described in the comments upgrade docs to account for a problem found with freecomments using Postgres. Thanks to rajeshd for the report.

comment:6 Changed 5 years ago by Jacob

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top