models.CommaSeperatedIntegerField doesn't return a forms field of any use

[Alex Gaynor]

CommaSeperatedIntegerField just returns a normal charfield, which obviously preforms no validation that it matches the purpose of the field.

[gkelly]

Patch to return formfield using regex

[Matt McClanahan]

Add admin widget

[Ivan Giuliani]

The regexp used in the patch is not completely right, it matches too many things:

>>> x = re.compile("^[\d,]+$")
>>> 
>>> type(x.match("1,2,3"))
<type '_sre.SRE_Match'>
>>> type(x.match(",1,2,3"))
<type '_sre.SRE_Match'>
>>> type(x.match("1,2,3,"))
<type '_sre.SRE_Match'>
>>> type(x.match("1,,,,2,,,,,3,,,"))
<type '_sre.SRE_Match'>
>>> type(x.match("1.2"))
<type 'NoneType'>
>>> type(x.match(",,,,,"))
<type '_sre.SRE_Match'>

I guess the problem is in "[\d,]" since the square brackets don't care about the order of the specified chars. Or maybe django should allow that strings?

[Jacob]

The regex is fine; all this needs is some tests.

[Ivan Giuliani]

Unit tests for this ticket

[Jacob]

(In [8682]) Fixed #8556: added a useful formfield to CommaSeparatedIntegerField. gkelly, mattmcc, and kratorius all contributed portions of this patch.

[Jacob]

Milestone 1.0 deleted