Some fixes for the makemessages management command

[Ramiro Morales]

The command doesn't correctly clean up after itself if an error condition is found when forking external GNU gettext utilities (xgettext, msgmerge, msgfmt), potentially leaving spurious temporary files (.pot, .js.py, .html.py) in the tree.

Also, some optimizations were made.

[Ramiro Morales]

Patch, applies to trunk as of r8534

[Jannis Leidel]

As far as I know it's not encouraged to combine patches for different tickets

[Malcolm Tredinnick]

I've deleted the patch that combines the two tickets so that it doesn't distract us. #7084 is a genuine bug fix. This ticket is about a clean up that, whilst useful to have, isn't critical. Leaving a couple of in-progress files around in the odd failure case is survivable. So we'll apply this, but it's lower priority than the other one.

[Ramiro Morales]

Replying to mtredinnick:

I've deleted the patch that combines the two tickets so that it doesn't distract us.

Sorry, I was in a rush to leave for work and posted that extra 'noisy' patch without too much thought. Because the same reason, the patch isn't what I meant to post: it is a cumulative one and I wanted to add an interdiff.

I agree this is low priority, just wanted to have it noted in a place more robust than my Hg repos so I don't forget this issue.

[Ramiro Morales]

Updated patch

[Jannis Leidel]

In [15506]:

Fixed #8536 -- Made sure the makemessages management command cleans up after throwing an error. Thanks to Ramiro for the initial patch.

[Julien Phalip]

In [17240]:

Ensured that makemessages doesn't leave any temporary file over if the parsing of a template file fails. Refs #8536.