Opened 16 years ago
Closed 13 years ago
#8527 closed New feature (fixed)
CAPostalCodeField made more forgiving of input format
| Reported by: | Doug Harris | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.localflavor | Version: | dev |
| Severity: | Normal | Keywords: | ca postal code |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
Similar to the work done in [6952] for #5670 for UKPostcodeField, this change is more forgiving of Canadian postal code input. Uppercase, lowercase, with or without a space in between the two segments.
The clean method returns a nice, clean version -- enter 'K1A 0A9', 'k1a 0A9', 'k1a0a9', or even ' k1A 0A9 ' and it will return the standard form: 'K1A 0A9'.
Patch contains code change and additions to regression tests.
Attachments (2)
Change History (9)
by , 16 years ago
| Attachment: | ca-form.diff added |
|---|
comment:1 by , 16 years ago
| milestone: | → post-1.0 |
|---|---|
| Triage Stage: | Unreviewed → Accepted |
Feature addition. Moving to post-1.0.
comment:3 by , 13 years ago
| Easy pickings: | set |
|---|---|
| Patch needs improvement: | set |
| Severity: | → Normal |
| Type: | → Cleanup/optimization |
The tests would need to be rewritten using unittests since this is now Django's preferred way.
comment:4 by , 13 years ago
| Type: | Cleanup/optimization → New feature |
|---|
comment:5 by , 13 years ago
| Patch needs improvement: | unset |
|---|
comment:6 by , 13 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
I reviewed this patch. It looks good and applies cleanly to revision 16169.
comment:7 by , 13 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
In [16175]:
(The changeset message doesn't reference this ticket)
Note:
See TracTickets
for help on using tickets.
Patch and tests