Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8499 closed (fixed)

Admin Fieldset changed css from 'error' to 'errors'

Reported by: Robert Myers Owned by: Robert Myers
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

It looks like it may have been just a little oversite. But the new admin changed the css that was applied to the form-row div. It use to be error now it is errors. While this may be technically correct it is a silly change to make since it will require everyone who was using error to style up the row differently.

Case point one: http://code.djangoproject.com/ticket/5873

I think that change should be reverted.

Also if this is not changed then you will need to alter the global.css file Here is the relevant part:

/* MESSAGES & ERRORS */

# snip #

.error { background:#ffc; }
.error input, .error select { border:1px solid red; }

And it should be listed in Backwards incompatible Changes if it is not reverted.

Attachments (3)

fieldset.patch (860 bytes) - added by Robert Myers 8 years ago.
fix fieldset error css
fieldset-2.patch (1.5 KB) - added by Robert Myers 8 years ago.
Forgot the change to revert 7576
8499.patch (1.0 KB) - added by Robert Myers 8 years ago.
Fair enough, here is a patch to correct the global.css to 'errors' from 'error'

Download all attachments as: .zip

Change History (9)

Changed 8 years ago by Robert Myers

Attachment: fieldset.patch added

fix fieldset error css

comment:1 Changed 8 years ago by Robert Myers

Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Changed 8 years ago by Robert Myers

Attachment: fieldset-2.patch added

Forgot the change to revert 7576

comment:2 Changed 8 years ago by Jacob

Resolution: wontfix
Status: newclosed

errors is a better name, and it's easy enough for folks to change their own CSS stylesheets. Let's not flip-flop, and leave it as is.

Changed 8 years ago by Robert Myers

Attachment: 8499.patch added

Fair enough, here is a patch to correct the global.css to 'errors' from 'error'

comment:3 Changed 8 years ago by Malcolm Tredinnick

Resolution: wontfix
Status: closedreopened

Reopening, since there's still a bug here (adding a patch to a closed ticket won't get it committed).

comment:4 Changed 8 years ago by anonymous

Sorry, I wasn't sure of the correct procedure. Whether I can or should have set it to 'reopen'. And I thought this was so minor it wasn't worth bringing up on django-developers.

comment:5 Changed 8 years ago by Brian Rosner

Resolution: fixed
Status: reopenedclosed

(In [8554]) Fixed #8499 -- Corrected a couple of instances of where the CSS class name error should be errors. Thanks rmyers for catching this.

comment:6 Changed 5 years ago by Jacob

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top