Code

Opened 6 years ago

Closed 6 years ago

#8390 closed (invalid)

typo in forms documentation

Reported by: Peter Etchells <peter.a.etchells@…> Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

max_decimal_places should be decimal_places in following:

DecimalField...
Error message keys: required, invalid, max_value, min_value, max_digits, max_decimal_places, max_whole_digits

Takes four optional arguments: max_value, min_value, max_digits, and decimal_places.

Attachments (0)

Change History (3)

comment:1 follow-up: Changed 6 years ago by thejaswi_puthraya

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

Can you post the exact link to the documentation showing those arguments?

I couldn't find a reference to max_decimal_places, max_value, min_value in either the documentation (1) or in the source (2).

(1) http://www.djangoproject.com/documentation/model-api/#decimalfield

(2) http://code.djangoproject.com/browser/django/trunk/django/db/models/fields/__init__.py#L668

comment:2 in reply to: ↑ 1 Changed 6 years ago by thejaswi_puthraya

Replying to thejaswi_puthraya:

Can you post the exact link to the documentation showing those arguments?

Sorry...my bad, overlooked the forms (1) documentation.
The error dict key is max_decimal_places (2). It has no connection with the optional arguments.

(1) http://www.djangoproject.com/documentation/forms/#decimalfield

(2) http://code.djangoproject.com/browser/django/trunk/django/forms/fields.py#L217

comment:3 Changed 6 years ago by Piotr Lewandowski <django@…>

  • Resolution set to invalid
  • Status changed from new to closed

As thejaswi_puthraya mentioned - max_decimal_places is a valid error message key.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.