Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8388 closed (fixed)

Wrong SortedDict call in db-api docs for extra(select=...)

Reported by: Samuel Cormier-Iijima Owned by: nobody
Component: Documentation Version: master
Severity: Keywords:
Cc: sciyoshi@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

SortedDict only expects one parameter which is iterable.

Blog.objects.extra(
    select=SortedDict(('a', '%s'), ('b', '%s')),
    select_params=('one', 'two'))

should therefore really be something like

Blog.objects.extra(
    select=SortedDict([('a', '%s'), ('b', '%s')]),
    select_params=('one', 'two'))

Attaching a patch that fixes this.

Attachments (1)

extra-doc.patch (485 bytes) - added by Samuel Cormier-Iijima 8 years ago.

Download all attachments as: .zip

Change History (5)

Changed 8 years ago by Samuel Cormier-Iijima

Attachment: extra-doc.patch added

comment:1 Changed 8 years ago by Thejaswi Puthraya

Triage Stage: UnreviewedAccepted

comment:2 Changed 8 years ago by Collin Grady

Triage Stage: AcceptedReady for checkin

comment:3 Changed 8 years ago by James Bennett

Resolution: fixed
Status: newclosed

(In [8478]) Fixed #8388: Corrected documentation for SortedDict use in extra()

comment:4 Changed 5 years ago by Jacob

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top