Opened 8 years ago

Closed 8 years ago

#8269 closed (wontfix)

sessions should only be marked modified when data actually changes

Reported by: Collin Grady Owned by: nobody
Component: contrib.sessions Version: master
Severity: Keywords:
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

the modified flag on sessions currently is set on any assignment, even if you put the same data, which can make for a lot of duplicate writes

Attachments (1)

only-save-sessions-when-modified.patch (608 bytes) - added by Collin Grady 8 years ago.

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by Collin Grady

comment:1 Changed 8 years ago by Collin Grady

hmm, just thought of one minor issue with this though - if you put a model instance in a key, it'll be 'equal' to another assignment as long as the ID matches, even if other data has changed

comment:2 Changed 8 years ago by Jacob

Resolution: wontfix
Status: newclosed

Yeah, if you don't want the session to be marked as changed, don't change the session. Comparing additions for equality could be very expensive, and that's a bad idea for sessions.

Note: See TracTickets for help on using tickets.
Back to Top