Opened 16 years ago
Closed 16 years ago
#8269 closed (wontfix)
sessions should only be marked modified when data actually changes
| Reported by: | Collin Grady | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.sessions | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
the modified flag on sessions currently is set on any assignment, even if you put the same data, which can make for a lot of duplicate writes
Attachments (1)
Change History (3)
by , 16 years ago
| Attachment: | only-save-sessions-when-modified.patch added |
|---|
comment:1 by , 16 years ago
comment:2 by , 16 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Yeah, if you don't want the session to be marked as changed, don't change the session. Comparing additions for equality could be very expensive, and that's a bad idea for sessions.
Note:
See TracTickets
for help on using tickets.
hmm, just thought of one minor issue with this though - if you put a model instance in a key, it'll be 'equal' to another assignment as long as the ID matches, even if other data has changed