Subpackage Settings Fix
|Reported by:||AdamG||Owned by:||russellm|
|Component:||Core (Management commands)||Version:||master|
|Has patch:||no||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
r8282 introduces a regression by adding a line like so:
I don't know why this line is used, but since __import__ returns the first package, even in a dotted expression like settings.development, this line has the net effect of running setup_environ on settings.__init__ instead of settings.development, which has, as you can imagine, negative effects - like breaking runserver (since it can't find any settings), and any management command that spawn a subprocess (which captures the new, incorrect DJANGO_SETTINGS_MODULE environment variable).
The attached patch fixes this.
(I'm guessing on the assignee, forgive me if I'm wrong.)
Change History (5)
Changed 6 years ago by AdamG
comment:1 Changed 6 years ago by brosner
- Needs documentation unset
- Needs tests unset
- Patch needs improvement unset
- Triage Stage changed from Unreviewed to Accepted