Admin form keyboard focus does not respect fields or fieldsets options

[mdhancher]

When you re-order the fields in an admin add form using the fields or fieldsets options in your ModelAdmin class, the initial keyboard focus in the admin add/change form does not respect it.

The keyboard focus is set by a JavaScript call to document.getElementById("id_foo").focus(), where the ID is specified in the change_form.html template as {{adminform.first_field.auto_id}}. So an underlying issue is that AdminForm.first_field() (in contrib/admin/options.py) does not respect the re-ordering. I am experiencing this using the current Subversion HEAD, revision 8272.

For example, consider this simple model in models.py:

class MyModel(models.Model):
    foo = models.CharField(max_length=255)
    bar = models.CharField(max_length=255)

and this simple admin configuration in admin.py:

class MyModelAdmin(admin.ModelAdmin):
    fields = ('bar', 'foo')

admin.site.register(MyModel,MyModelAdmin)

Then try to add a new MyModel object using the admin interface, and notice that they keyboard focus starts out at the bottom rather than the top of the form.

[Fred Bartle <fredbartle@…>]

sets focus to first field in admin

[Fred Bartle <fredbartle@…>]

Added patch that respects fields or fieldsets specified in ModelAdmin. Required access to forms.BoundField.

[Fred Bartle <fredbartle@…>]

Fixed a typo in the first patch.

[Fred Bartle]

Suppose I should check this box!

[Jacob]

(In [8681]) Fixed #8194: AdminForm.first_field now correctly returns the first field when using custom field orders.

[Fred Bartle]

I'm reopening because forms.BoundField is not accessible for this patch to work. As of r8681, if admin fields or fieldsets are specified, the following html is created from the template:

<script type="text/javascript">document.getElementById("").focus();</script>

Using a try/except block around L25 in django/contrib/admin/helpers.py shows an AttributeError being raised.

'module' object has no attribute 'BoundField'

Just a side question here, I'm listed under AUTHORS as 'hambaloney' for another ticket I was involved with, is it possible to change that to my name?

[Fred Bartle]

Allows access to BoundField

[Jacob]

(In [8774]) Fixed #8194 (again): correctly focus on the first declared field in the admin. Thanks to fredbartle for catching my silly mistake the first time 'round.

[Jacob]

Milestone 1.0 deleted