If I create an UploadedFile with a unicode name that contains non-ASCII chars, I get a UnicodeEncodeError attempting to display its representation in a Python shell:
>>> from django.core.files.uploadedfile import UploadedFile
>>> uf = UploadedFile(name=u'¿Cómo',content_type='text')
>>> uf
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
UnicodeEncodeError: 'ascii' codec can't encode character u'\xbf' in position 15: ordinal not in range(128)
>>> uf.__repr__()
u'<UploadedFile: \xbfC\xf3mo (text)>'
The implementation of __repr__ here is:
def __repr__(self):
return "<%s: %s (%s)>" % (self.__class__.__name__, self.name, self.content_type)
I think __repr__ for UploadedFile needs to take into account the fact that the file name may be Unicode with non-ASCII chars and convert it into an ASCII-only representation before including it in the return value. As it is this implementation returns unicode, where I thought __repr__ was supposed to return only a string (per http://docs.python.org/ref/customization.html "The return value must be a string object.")?
hi, this is my first patch :)
this patch checks if the name is unicode, and if it is, uses its repr instead.