#8151 closed (fixed)
UnicodeDecodeError from /django/contrib/admin/options.py in save_change
Reported by: | Karen Tracey | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Keywords: | ||
Cc: | eallik@… | Triage Stage: | Accepted |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
As reported here: http://groups.google.com/group/django-users/msg/845d2a8899bbb57c
The failing line of code in the dpaste traceback is:
File "/home/rime/www/tammeoue/packages/django/contrib/admin/options.py" in save_change 431. msg = _('The %(name)s "%(obj)s" was changed successfully.') % {'name': force_unicode(opts.verbose_name), 'obj': new_object}
This is similar to #7992/#8016 -- some code that moved from django/contrib/admin/views/main.py in old admin to django/contrib/admin/options.py in newforms-admin was missed when the Unicode changes were merged from trunk to newforms-admin. The corresponding line of code in pre-NFA (http://code.djangoproject.com/browser/django/tags/notable_moments/pre-newforms-admin/django/contrib/admin/views/main.py#L354) is:
msg = _('The %(name)s "%(obj)s" was changed successfully.') % {'name': force_unicode(opts.verbose_name), 'obj': force_unicode(new_object)}
That is, there is a force_unicode around the new_object
as well as opts.verbose_name
. It's probably worth a closer look to see if any other places have been missed; I'll do this when I get a chance but don't wait on me to fix it if someone else gets to it first.
Change History (7)
comment:1 by , 16 years ago
comment:2 by , 16 years ago
Cc: | added |
---|
comment:3 by , 16 years ago
comment:4 by , 16 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:5 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
I'm not sure why this ticket was reopened. Probably a mistake. It seems that the reported issue has been fixed in [8236].
comment:6 by , 16 years ago
Correction: it was not reopened, but it hadn't been closed (as I guessed it should have been).
#8153 reports the same problem and includes a patch that catches one more instance of missing force_unicode wrapper.