Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#8121 closed (fixed)

LocaleMiddleware should not set Content-Language header if already present

Reported by: jcassee Owned by: nobody
Component: Internationalization Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The user may have added the Content-Language header to the Response objects explicitely. In that case LocaleMiddleware should not overwrite it. Attached patch fixes this.

Attachments (1)

8121-r8137.diff (575 bytes) - added by jcassee 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by jcassee

comment:1 Changed 7 years ago by ericholscher

  • milestone set to 1.0
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by mtredinnick

  • Resolution set to fixed
  • Status changed from new to closed

(In [8259]) Fixed #8121 -- Don't override the Content-Language HTTP header in the locale
middleware if it's already been set. Thanks, jcassee.

comment:3 Changed 4 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top