Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#8084 closed (wontfix)

Int division in int_to_base_36

Reported by: jshaffer Owned by: ericholscher
Component: Uncategorized Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


For forward compatibility, int_to_base_36 should use explicit integer division.

Attachments (1)

8084.patch (429 bytes) - added by jshaffer 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by jshaffer

comment:1 Changed 7 years ago by ericholscher

  • milestone set to 1.0
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to ericholscher
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by mtredinnick

  • Resolution set to wontfix
  • Status changed from assigned to closed

The current code isn't wrong. Python 2.x will always treat dividing integers as integer division and we're not porting to 3.x yet. Thanks for the patch, but let's not start of trend of hunting all these out at the moment.

comment:3 Changed 4 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top