Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8084 closed (wontfix)

Int division in int_to_base_36

Reported by: John Shaffer Owned by: Eric Holscher
Component: Uncategorized Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

For forward compatibility, int_to_base_36 should use explicit integer division.

Attachments (1)

8084.patch (429 bytes) - added by John Shaffer 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by John Shaffer

Attachment: 8084.patch added

comment:1 Changed 8 years ago by Eric Holscher

milestone: 1.0
Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to Eric Holscher
Patch needs improvement: unset
Status: newassigned
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 8 years ago by Malcolm Tredinnick

Resolution: wontfix
Status: assignedclosed

The current code isn't wrong. Python 2.x will always treat dividing integers as integer division and we're not porting to 3.x yet. Thanks for the patch, but let's not start of trend of hunting all these out at the moment.

comment:3 Changed 5 years ago by Jacob

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top