Opened 8 years ago

Closed 17 months ago

#8079 closed Bug (wontfix)

Admindocs bookmarklets assume a single admin site

Reported by: MattBowen Owned by: Ben Spaulding
Component: contrib.admindocs Version: master
Severity: Normal Keywords: admindocs, admin
Cc: Triage Stage: Someday/Maybe
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In django.contrib.admindocs.views.bookmarklets, to generate the bookmarklets, the function assumes (in lines 34-35)

  1. Admin docs will be at admin/docs
  2. There is only one admin site

It uses these two assumptions to determine the urls of the admindocs and of the admin site for generating the URLs the bookmarklets need to communicate with the admin interface. Using named URLs from #7810 makes (1) easy to fix. That will only fix one bookmarklet (the one that goes to the documentation pages). (2) is a faulty assumption though; there can now be multiple admin sites.

From what I can tell, the bookmarklets page of the admindocs app needs to be rethought now that there can be multiple admin sites; it seems that each admin site needs its own bookmarklets.

Change History (11)

comment:1 Changed 8 years ago by Eric Holscher

milestone: post-1.0
Owner: changed from nobody to Eric Holscher
Status: newassigned

comment:2 Changed 8 years ago by Eric Holscher

Triage Stage: UnreviewedSomeday/Maybe

comment:3 Changed 8 years ago by Eric Holscher

Owner: Eric Holscher deleted
Status: assignednew

comment:4 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:5 Changed 6 years ago by Luke Plant

Severity: Normal
Type: Bug

comment:6 Changed 5 years ago by Aymeric Augustin

UI/UX: unset

Change UI/UX from NULL to False.

comment:7 Changed 5 years ago by Aymeric Augustin

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:8 Changed 4 years ago by Aymeric Augustin

Component: contrib.admincontrib.admindocs

comment:9 Changed 17 months ago by Ben Spaulding

Owner: set to Ben Spaulding
Status: newassigned

comment:10 Changed 17 months ago by Ben Spaulding

I think this bug should be marked as wontfix because the bookmarklets in question do not work any more, and have not in years (since #13285 was closed). And adding multi-admin support would be difficult and messy. Finally, if ticket #25115 is accepted, this ticket will no longer be valid.

comment:11 Changed 17 months ago by Aymeric Augustin

Resolution: wontfix
Status: assignedclosed
Note: See TracTickets for help on using tickets.
Back to Top