Opened 7 years ago

Last modified 2 years ago

#8079 new Bug

Admindocs bookmarklets assume a single admin site

Reported by: MattBowen Owned by:
Component: contrib.admindocs Version: master
Severity: Normal Keywords: admindocs, admin
Cc: Triage Stage: Someday/Maybe
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

In django.contrib.admindocs.views.bookmarklets, to generate the bookmarklets, the function assumes (in lines 34-35)

  1. Admin docs will be at admin/docs
  2. There is only one admin site

It uses these two assumptions to determine the urls of the admindocs and of the admin site for generating the URLs the bookmarklets need to communicate with the admin interface. Using named URLs from #7810 makes (1) easy to fix. That will only fix one bookmarklet (the one that goes to the documentation pages). (2) is a faulty assumption though; there can now be multiple admin sites.

From what I can tell, the bookmarklets page of the admindocs app needs to be rethought now that there can be multiple admin sites; it seems that each admin site needs its own bookmarklets.

Change History (8)

comment:1 Changed 7 years ago by ericholscher

  • milestone set to post-1.0
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to ericholscher
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 7 years ago by ericholscher

  • Triage Stage changed from Unreviewed to Someday/Maybe

comment:3 Changed 7 years ago by ericholscher

  • Owner ericholscher deleted
  • Status changed from assigned to new

comment:4 Changed 6 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:5 Changed 4 years ago by lukeplant

  • Severity set to Normal
  • Type set to Bug

comment:6 Changed 3 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:7 Changed 3 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:8 Changed 2 years ago by aaugustin

  • Component changed from contrib.admin to contrib.admindocs
Note: See TracTickets for help on using tickets.
Back to Top