#8069 closed (fixed)
inconsistent case for class BaseInlineFormset
| Reported by: | dan | Owned by: | Brian Rosner |
|---|---|---|---|
| Component: | Forms | Version: | master |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | UI/UX: |
Description
BaseInlineFormset, unlike all other class names derived from FormSet classes, uses "Formset", instead of "FormSet". This is an annoying inconsistency.
Attachments (1)
Change History (6)
Changed 9 years ago by
| Attachment: | ticket8069-1.diff added |
|---|
comment:1 Changed 9 years ago by
| Component: | Uncategorized → django.newforms |
|---|---|
| Owner: | changed from nobody to dan |
| Status: | new → assigned |
| Summary: | inconsistent case for class BaseInlilneFormset → inconsistent case for class BaseInlineFormset |
My patch addresses the use of inconsistent casing in code. So far as i can see, this is the only class in the core that capitalises FormSet in this particular way. There are examples of "Formset" popping up in a few code comments, docstrings and examples, but as these are plain english so the case is less strong for patching them.
comment:2 Changed 9 years ago by
| milestone: | → 1.0 |
|---|---|
| Triage Stage: | Unreviewed → Ready for checkin |
comment:3 Changed 9 years ago by
| Owner: | changed from dan to Brian Rosner |
|---|---|
| Status: | assigned → new |
comment:4 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
patch addressing inconsistent case of BaseInlineFormSet