Code

Opened 6 years ago

Closed 6 years ago

Last modified 3 years ago

#8069 closed (fixed)

inconsistent case for class BaseInlineFormset

Reported by: dan90 Owned by: brosner
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

BaseInlineFormset, unlike all other class names derived from FormSet classes, uses "Formset", instead of "FormSet". This is an annoying inconsistency.

Attachments (1)

ticket8069-1.diff (2.9 KB) - added by dan90 6 years ago.
patch addressing inconsistent case of BaseInlineFormSet

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by dan90

patch addressing inconsistent case of BaseInlineFormSet

comment:1 Changed 6 years ago by dan90

  • Component changed from Uncategorized to django.newforms
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to dan90
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Summary changed from inconsistent case for class BaseInlilneFormset to inconsistent case for class BaseInlineFormset

My patch addresses the use of inconsistent casing in code. So far as i can see, this is the only class in the core that capitalises FormSet in this particular way. There are examples of "Formset" popping up in a few code comments, docstrings and examples, but as these are plain english so the case is less strong for patching them.

comment:2 Changed 6 years ago by ericholscher

  • milestone set to 1.0
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:3 Changed 6 years ago by brosner

  • Owner changed from dan90 to brosner
  • Status changed from assigned to new

comment:4 Changed 6 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [8243]) Fixed #8069 -- Corrected the inconsistent case with BaseInlineFormset. It has been renamed to BaseInlineFormSet. Backward incompatible for anyone who used BaseInlineFormset directly.

comment:5 Changed 3 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.