#8069 closed (fixed)
inconsistent case for class BaseInlineFormset
| Reported by: | dan90 | Owned by: | brosner |
|---|---|---|---|
| Component: | Forms | Version: | master |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | UI/UX: |
Description
BaseInlineFormset, unlike all other class names derived from FormSet classes, uses "Formset", instead of "FormSet". This is an annoying inconsistency.
Attachments (1)
Change History (6)
Changed 6 years ago by dan90
comment:1 Changed 6 years ago by dan90
- Component changed from Uncategorized to django.newforms
- Needs documentation unset
- Needs tests unset
- Owner changed from nobody to dan90
- Patch needs improvement unset
- Status changed from new to assigned
- Summary changed from inconsistent case for class BaseInlilneFormset to inconsistent case for class BaseInlineFormset
My patch addresses the use of inconsistent casing in code. So far as i can see, this is the only class in the core that capitalises FormSet in this particular way. There are examples of "Formset" popping up in a few code comments, docstrings and examples, but as these are plain english so the case is less strong for patching them.
comment:2 Changed 6 years ago by ericholscher
- milestone set to 1.0
- Triage Stage changed from Unreviewed to Ready for checkin
comment:3 Changed 6 years ago by brosner
- Owner changed from dan90 to brosner
- Status changed from assigned to new
comment:4 Changed 6 years ago by brosner
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
patch addressing inconsistent case of BaseInlineFormSet