Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8069 closed (fixed)

inconsistent case for class BaseInlineFormset

Reported by: dan Owned by: Brian Rosner
Component: Forms Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


BaseInlineFormset, unlike all other class names derived from FormSet classes, uses "Formset", instead of "FormSet". This is an annoying inconsistency.

Attachments (1)

ticket8069-1.diff (2.9 KB) - added by dan 8 years ago.
patch addressing inconsistent case of BaseInlineFormSet

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by dan

Attachment: ticket8069-1.diff added

patch addressing inconsistent case of BaseInlineFormSet

comment:1 Changed 8 years ago by dan

Component: Uncategorizeddjango.newforms
Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to dan
Patch needs improvement: unset
Status: newassigned
Summary: inconsistent case for class BaseInlilneFormsetinconsistent case for class BaseInlineFormset

My patch addresses the use of inconsistent casing in code. So far as i can see, this is the only class in the core that capitalises FormSet in this particular way. There are examples of "Formset" popping up in a few code comments, docstrings and examples, but as these are plain english so the case is less strong for patching them.

comment:2 Changed 8 years ago by Eric Holscher

milestone: 1.0
Triage Stage: UnreviewedReady for checkin

comment:3 Changed 8 years ago by Brian Rosner

Owner: changed from dan to Brian Rosner
Status: assignednew

comment:4 Changed 8 years ago by Brian Rosner

Resolution: fixed
Status: newclosed

(In [8243]) Fixed #8069 -- Corrected the inconsistent case with BaseInlineFormset. It has been renamed to BaseInlineFormSet. Backward incompatible for anyone who used BaseInlineFormset directly.

comment:5 Changed 5 years ago by Jacob

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top