Opened 17 years ago

Closed 17 years ago

Last modified 13 years ago

#8069 closed (fixed)

inconsistent case for class BaseInlineFormset

Reported by: dan Owned by: Brian Rosner
Component: Forms Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no
Pull Requests:How to create a pull request

Description

BaseInlineFormset, unlike all other class names derived from FormSet classes, uses "Formset", instead of "FormSet". This is an annoying inconsistency.

Change History (6)

by dan, 17 years ago

Attachment: ticket8069-1.diff added

patch addressing inconsistent case of BaseInlineFormSet

comment:1 by dan, 17 years ago

Component: Uncategorizeddjango.newforms
Owner: changed from nobody to dan
Status: newassigned
Summary: inconsistent case for class BaseInlilneFormsetinconsistent case for class BaseInlineFormset

My patch addresses the use of inconsistent casing in code. So far as i can see, this is the only class in the core that capitalises FormSet in this particular way. There are examples of "Formset" popping up in a few code comments, docstrings and examples, but as these are plain english so the case is less strong for patching them.

comment:2 by Eric Holscher, 17 years ago

milestone: 1.0
Triage Stage: UnreviewedReady for checkin

comment:3 by Brian Rosner, 17 years ago

Owner: changed from dan to Brian Rosner
Status: assignednew

comment:4 by Brian Rosner, 17 years ago

Resolution: fixed
Status: newclosed

(In [8243]) Fixed #8069 -- Corrected the inconsistent case with BaseInlineFormset. It has been renamed to BaseInlineFormSet. Backward incompatible for anyone who used BaseInlineFormset directly.

comment:5 by Jacob, 13 years ago

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top