Opened 8 years ago

Closed 8 years ago

Last modified 5 years ago

#8067 closed (fixed)

model_formsets test uses dict literals

Reported by: Leo Soto M. Owned by: Brian Rosner
Component: Testing framework Version: master
Severity: Keywords: jython
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

As seen in the past, dict literals are fragile for doctests, as the key ordering is implementation dependent.

The patch fixes this for model_formsets/models.py

Attachments (1)

no_dicts_literal_on_doctests.diff (1.3 KB) - added by Leo Soto M. 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Leo Soto M.

comment:1 Changed 8 years ago by Brian Rosner

Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to Brian Rosner
Patch needs improvement: unset
Status: newassigned
Triage Stage: UnreviewedReady for checkin

comment:2 Changed 8 years ago by Brian Rosner

Resolution: fixed
Status: assignedclosed

(In [8178]) Fixed #8067 -- Replaced dict literals in the model_formsets tests with sorted lists of tuples to ensure compatibilty on different implementations of Python. Thanks Leo Soto for the patch.

comment:3 Changed 5 years ago by Jacob

milestone: 1.0

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top