Opened 7 years ago

Closed 7 years ago

Last modified 3 years ago

#8067 closed (fixed)

model_formsets test uses dict literals

Reported by: leosoto Owned by: brosner
Component: Testing framework Version: master
Severity: Keywords: jython
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

As seen in the past, dict literals are fragile for doctests, as the key ordering is implementation dependent.

The patch fixes this for model_formsets/models.py

Attachments (1)

no_dicts_literal_on_doctests.diff (1.3 KB) - added by leosoto 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by leosoto

comment:1 Changed 7 years ago by brosner

  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to brosner
  • Patch needs improvement unset
  • Status changed from new to assigned
  • Triage Stage changed from Unreviewed to Ready for checkin

comment:2 Changed 7 years ago by brosner

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8178]) Fixed #8067 -- Replaced dict literals in the model_formsets tests with sorted lists of tuples to ensure compatibilty on different implementations of Python. Thanks Leo Soto for the patch.

comment:3 Changed 3 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top