Opened 8 years ago

Closed 8 years ago

#8059 closed (fixed)

m2m_through test hasn't a really predictable output

Reported by: Ramiro Morales Owned by: nobody
Component: Testing framework Version: master
Severity: Keywords: m2m_through db backend output modeltests
Cc: Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

One of the tests for this new functionality:

http://code.djangoproject.com/browser/django/trunk/tests/modeltests/m2m_through/models.py#L329

runs successfully with all (some?) the builtin DB backends, but from what can be seen in the model definitions and the data handling made in the tests leading to that specific test, there isn't an unique 'correct' output order.

This is showing a a failure when running the test suite against another external DB backend.

The attached patch solves this adding another item to the membership.meta.ordering tuple.

Attachments (1)

t8059.diff (541 bytes) - added by Ramiro Morales 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Ramiro Morales

Attachment: t8059.diff added

comment:1 Changed 8 years ago by Ramiro Morales

Has patch: set
Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

comment:3 Changed 8 years ago by Russell Keith-Magee

Resolution: fixed
Status: newclosed

(In [8166]) Fixed #8059 -- Added additional clarification to the ordering of Memberships so that output order is predictable in tests. Thanks to ramiro for the report and fix.

Note: See TracTickets for help on using tickets.
Back to Top