Code

Opened 6 years ago

Closed 3 years ago

#8052 closed Bug (fixed)

Password Change Forms overrides userlinks

Reported by: mikeblake Owned by:
Component: contrib.admin Version: master
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

Password change form explicitly sets

   {% block userlinks %}

which is preventing custom templates from showing through for that portion of the page.

ie: I have a template called admin/base_site.html which includes the {% block userlinks %} but does not have the documentation link. However on the change password form, the old format (with the Documentation hyperlink), is showing up instead.

A quick flick through the admin templates shows this may be redundant and removing the line fixes it.

SVN 8151

Attachments (1)

password_change_8052.diff (775 bytes) - added by mikeblake 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by mikeblake

comment:1 Changed 6 years ago by ericholscher

  • Component changed from Uncategorized to Admin interface
  • Has patch set
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from nobody to ericholscher
  • Patch needs improvement unset
  • Status changed from new to assigned

comment:2 Changed 6 years ago by ericholscher

  • Triage Stage changed from Unreviewed to Accepted

comment:3 Changed 6 years ago by ericholscher

  • Owner ericholscher deleted
  • Status changed from assigned to new

comment:4 Changed 6 years ago by zegor

  • Summary changed from Password Change Form overrides userlinks to Password Change Forms overrides userlinks

Same problem in password_change_done.html

comment:5 Changed 6 years ago by kmtracey

  • Patch needs improvement set

The problem with removing the {% block userlinks %} from password_change_form.html and password_change_done.html is that the "change password" and "logout" links inherited from the default admin/base_site.html are wrong on these pages. #8984 covers fixing the "Documentation" link for these pages, and #8933 proposes making these templates overridable. I think once either of those is fixed, the reason for this ticket goes away, right?

comment:6 Changed 3 years ago by lukeplant

  • Severity set to Normal
  • Type set to Bug

comment:7 Changed 3 years ago by ramiro

  • Easy pickings unset
  • Resolution set to fixed
  • Status changed from new to closed
  • UI/UX unset

Fixed in r9079 and r12217. You can now provide your custom templates for change password-related views if you need this kind of customization.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.