python process crashes when using sitemaps after [8088]

[Boo]

When I go to ​http://example.com/sitemap.xml, python process crashes without any errors or core dumps.

Django-version: trunk after [8088]
DB-backends: PostgreSQL or SQLite3
URLs in sitemap: less than 50000

[Malcolm Tredinnick]

There isn't really enough information here to work out what's going on or what the problem being reported is. You say "it crashed", but what do you mean? How can we replicate the problem? Do you have a small example that shows what is going on?

A problem that cannot be repeated cannot be fixed.

[Boo]

TestCase to repeat the problem

[Boo]

I've added TestCase to repeat this problem.
I use Python-2.5.2, OS: FreeBSD and MacOSX.

I run development server and go to ​http://127.0.0.1:8000/sitemap.xml, and devserver crushes without any errors.

Boo:~/projects/testcase boo$ ./manage.py runserver
Validating models...
0 errors found

Django version 1.0-alpha-SVN-8138, using settings 'testcase.settings'
Development server is running at http://127.0.0.1:8000/
Quit the server with CONTROL-C.
Boo:~/projects/testcase boo$

[evan_schulz]

As long as I add "django.contrib.sitemaps" to INSTALLED_APPS the attached test case works fine for me: displaying the sitemap file without any sign of errors or crashing. I happen to be at changeset [8156] on python 2.5.2.

[Boo]

Corrected INSTALLED_APPS

[Julian Bez]

The test case works for me. Python 2.5.2 at [8161]

[John D'Agostino]

fixes development server crash sitemaps framework

[John D'Agostino]

I can reproduce this on MacOSX with Python 2.5.1 The attached patch fixes the crash for me.

from django.contrib.sitemaps import Sitemap
from blog.models import Post

class PostSitemap(Sitemap):
    changefreq = "never"
    priority = 0.5

    def items(self):
        return Post.objects.all()

    def lastmod(self, obj):
        return obj.pub_date

[Julian Bez]

Seems obvious...

[Malcolm Tredinnick]

(In [8231]) Fixed #8020 -- Fixed paginator initialisation in sitemaps framework. Thanks,
John D'Agostino.

[Henrik Vendelbo]

This change recurses for me on Mac OSX, I don't understand why it wouldn't infinitely recurse on all platforms???

Is it because I changed the Sitemap class to a new-style class?

get_urls gets the paginator entering _get_paginator
It already has the property paginator, so
it returns the property paginator which triggers a call to _get_paginator
as it already has ....

[Henrik Vendelbo]

I believe reverting the fix and making Sitemaps new-style classes fixes the cause of this ticket.

[Malcolm Tredinnick]

From your description, it sounds like you are running a version from earlier than [8231], where the infinite loop problem with referring to a bad attribute was fixed. So I'm going to reclose this.

If you are still seeing a problem on unmodified code that is up to date, please open a new ticket explaining how to repeat the problem.

[Jacob]

Milestone 1.0 deleted