Opened 8 years ago

Closed 5 years ago

#8013 closed New feature (fixed)

Localflavor for Colombia and Ecuador

Reported by: Igor Támara Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Normal Keywords: Colombia Ecuador
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This is intended to add a basic localflavor for Colombia and Ecuador.

Attachments (4)

localflavor-coec.patch (6.3 KB) - added by Igor Támara 8 years ago.
localflavor-co_ec.diff (10.0 KB) - added by Bernhard Essl 5 years ago.
localflavor-co_ec-2.diff (9.9 KB) - added by Bernhard Essl 5 years ago.
localflavor-co_ec-3.diff (10.0 KB) - added by Bernhard Essl 5 years ago.

Download all attachments as: .zip

Change History (19)

Changed 8 years ago by Igor Támara

Attachment: localflavor-coec.patch added

comment:1 Changed 8 years ago by Malcolm Tredinnick

milestone: 1.0 beta

comment:2 Changed 8 years ago by Eric Holscher

milestone: post-1.0
Triage Stage: UnreviewedDesign decision needed

comment:3 Changed 8 years ago by Eric Holscher

milestone: post-1.01.0 maybe

comment:4 Changed 8 years ago by Jacob

milestone: 1.0 maybepost-1.0
Triage Stage: Design decision neededAccepted

comment:5 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:6 Changed 7 years ago by Jannis Leidel

milestone: 1.2
Needs tests: set

The patch is missing the tests, even though it refers to them.

comment:7 Changed 7 years ago by Russell Keith-Magee

milestone: 1.2
Version: SVN

comment:8 Changed 6 years ago by Luke Plant

Severity: Normal
Type: New feature

comment:9 Changed 5 years ago by Jannis Leidel

Easy pickings: unset
Patch needs improvement: set
UI/UX: unset

Changed 5 years ago by Bernhard Essl

Attachment: localflavor-co_ec.diff added

comment:10 Changed 5 years ago by Bernhard Essl

Needs tests: unset
Version: SVN

I updated the original patch with ISO keys and wrote tests.

Changed 5 years ago by Bernhard Essl

Attachment: localflavor-co_ec-2.diff added

comment:11 Changed 5 years ago by Bernhard Essl

Patch needs improvement: unset

comment:12 Changed 5 years ago by Jannis Leidel

The choices could use a whitespace after the each first item, but other than that this looks good.

Changed 5 years ago by Bernhard Essl

Attachment: localflavor-co_ec-3.diff added

comment:13 Changed 5 years ago by Bernhard Essl

added whitespace to the choices.

comment:14 Changed 5 years ago by Jannis Leidel

Triage Stage: AcceptedReady for checkin

comment:15 Changed 5 years ago by Jannis Leidel

Resolution: fixed
Status: newclosed

In [16570]:

Fixed #8013 -- Added Columbian and Ecuadorian local flavor. Thanks, ikks and Bernhard Essl.

Note: See TracTickets for help on using tickets.
Back to Top