Opened 16 years ago

Closed 13 years ago

#8013 closed New feature (fixed)

Localflavor for Colombia and Ecuador

Reported by: Igor Támara Owned by: nobody
Component: contrib.localflavor Version: dev
Severity: Normal Keywords: Colombia Ecuador
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This is intended to add a basic localflavor for Colombia and Ecuador.

Attachments (4)

localflavor-coec.patch​ (6.3 KB ) - added by Igor Támara 16 years ago.
localflavor-co_ec.diff​ (10.0 KB ) - added by Bernhard Essl 13 years ago.
localflavor-co_ec-2.diff​ (9.9 KB ) - added by Bernhard Essl 13 years ago.
localflavor-co_ec-3.diff​ (10.0 KB ) - added by Bernhard Essl 13 years ago.

Download all attachments as: .zip

Change History (19)

by Igor Támara, 16 years ago

Attachment: localflavor-coec.patch​ added

comment:1 by Malcolm Tredinnick, 16 years ago

milestone: 1.0 beta

comment:2 by Eric Holscher, 16 years ago

milestone: → post-1.0
Triage Stage: Unreviewed → Design decision needed

comment:3 by Eric Holscher, 16 years ago

milestone: post-1.0 → 1.0 maybe

comment:4 by Jacob, 16 years ago

milestone: 1.0 maybe → post-1.0
Triage Stage: Design decision needed → Accepted

comment:5 by (none), 16 years ago

milestone: post-1.0

Milestone post-1.0 deleted

comment:6 by Jannis Leidel, 15 years ago

milestone: → 1.2
Needs tests: set

The patch is missing the tests, even though it refers to them.

comment:7 by Russell Keith-Magee, 15 years ago

milestone: 1.2
Version: SVN

comment:8 by Luke Plant, 14 years ago

Severity: → Normal
Type: → New feature

comment:9 by Jannis Leidel, 13 years ago

Easy pickings: unset
Patch needs improvement: set
UI/UX: unset

by Bernhard Essl, 13 years ago

Attachment: localflavor-co_ec.diff​ added

comment:10 by Bernhard Essl, 13 years ago

Needs tests: unset
Version: → SVN

I updated the original patch with ISO keys and wrote tests.

by Bernhard Essl, 13 years ago

Attachment: localflavor-co_ec-2.diff​ added

comment:11 by Bernhard Essl, 13 years ago

Patch needs improvement: unset

comment:12 by Jannis Leidel, 13 years ago

The choices could use a whitespace after the each first item, but other than that this looks good.

by Bernhard Essl, 13 years ago

Attachment: localflavor-co_ec-3.diff​ added

comment:13 by Bernhard Essl, 13 years ago

added whitespace to the choices.

comment:14 by Jannis Leidel, 13 years ago

Triage Stage: Accepted → Ready for checkin

comment:15 by Jannis Leidel, 13 years ago

Resolution: → fixed
Status: new → closed

In [16570]:

Fixed #8013 -- Added Columbian and Ecuadorian local flavor. Thanks, ikks and Bernhard Essl.

Note: See TracTickets for help on using tickets.
Back to Top