Opened 7 years ago

Closed 4 years ago

#8013 closed New feature (fixed)

Localflavor for Colombia and Ecuador

Reported by: ikks Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Normal Keywords: Colombia Ecuador
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

This is intended to add a basic localflavor for Colombia and Ecuador.

Attachments (4)

localflavor-coec.patch (6.3 KB) - added by ikks 7 years ago.
localflavor-co_ec.diff (10.0 KB) - added by BernhardEssl 4 years ago.
localflavor-co_ec-2.diff (9.9 KB) - added by BernhardEssl 4 years ago.
localflavor-co_ec-3.diff (10.0 KB) - added by BernhardEssl 4 years ago.

Download all attachments as: .zip

Change History (19)

Changed 7 years ago by ikks

comment:1 Changed 7 years ago by mtredinnick

  • milestone 1.0 beta deleted
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset

comment:2 Changed 7 years ago by ericholscher

  • milestone set to post-1.0
  • Triage Stage changed from Unreviewed to Design decision needed

comment:3 Changed 7 years ago by ericholscher

  • milestone changed from post-1.0 to 1.0 maybe

comment:4 Changed 7 years ago by jacob

  • milestone changed from 1.0 maybe to post-1.0
  • Triage Stage changed from Design decision needed to Accepted

comment:5 Changed 6 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:6 Changed 5 years ago by jezdez

  • milestone set to 1.2
  • Needs tests set

The patch is missing the tests, even though it refers to them.

comment:7 Changed 5 years ago by russellm

  • milestone 1.2 deleted
  • Version SVN deleted

comment:8 Changed 4 years ago by lukeplant

  • Severity set to Normal
  • Type set to New feature

comment:9 Changed 4 years ago by jezdez

  • Easy pickings unset
  • Patch needs improvement set
  • UI/UX unset

Changed 4 years ago by BernhardEssl

comment:10 Changed 4 years ago by BernhardEssl

  • Needs tests unset
  • Version set to SVN

I updated the original patch with ISO keys and wrote tests.

Changed 4 years ago by BernhardEssl

comment:11 Changed 4 years ago by BernhardEssl

  • Patch needs improvement unset

comment:12 Changed 4 years ago by jezdez

The choices could use a whitespace after the each first item, but other than that this looks good.

Changed 4 years ago by BernhardEssl

comment:13 Changed 4 years ago by BernhardEssl

added whitespace to the choices.

comment:14 Changed 4 years ago by jezdez

  • Triage Stage changed from Accepted to Ready for checkin

comment:15 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from new to closed

In [16570]:

Fixed #8013 -- Added Columbian and Ecuadorian local flavor. Thanks, ikks and Bernhard Essl.

Note: See TracTickets for help on using tickets.
Back to Top