Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#801 closed defect (invalid)

contrib.comments seems a bit "unready"

Reported by: hugo Owned by: adrian
Component: contrib.comments Version:
Severity: normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


There are parts in django.contrib.comments that just don't look like it's fully coded. One thing that springs to mind is the support for extra_kwargs in the CommentListNode class, which is missing any way of passing this from the DoCommentList function - you can't create any extra_kwargs. Another is the approved and is_public bools that are avaialable, but never tested (I think at least the is_public should be taken into account with the get_comment_count and get_comment_list tags). Then there is the fact that the CommentListNode class allows extra_kwargs, but the CommentCountNode doesn't - so even if the tags would allow to pass additional keyword arguments for lookup, the list would respect them, while the count wouldn't.

Maybe this should be fleshed out a bit more before 1.0 ;-)

Change History (3)

comment:1 Changed 10 years ago by adrian

  • Component changed from Tools to django.contrib.comments

comment:2 Changed 10 years ago by adrian

  • Resolution set to invalid
  • Status changed from new to closed

Closing this because it's too generic. We're going to rewrite the comments app before documenting it, and that should fix these issues and more.

comment:3 Changed 10 years ago by anonymous

  • milestone Version 1.0 deleted

Milestone Version 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top