Opened 7 years ago

Closed 3 years ago

#7994 closed New feature (invalid)

Dutch Bank Account Number Field

Reported by: Rudolph Owned by: nobody
Component: contrib.localflavor Version: master
Severity: Normal Keywords: localflavorsplit
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

I created a Dutch Bank Account Number Field to the Dutch localflavor and also included tests.

Attachments (4)

DutchBankAccountNumberField.diff (5.8 KB) - added by Rudolph 7 years ago.
Removed a typo and altered the comments.
DutchBankAccountNumberField.2.diff (5.8 KB) - added by Rudolph 7 years ago.
Removed a typo and altered the comments.
DutchBankAccountNumberField.3.diff (8.8 KB) - added by Rudolph 7 years ago.
Removed a typo and altered the comments (sorry, previous patch did not change anything)
DutchBankAccountNumberField.4.diff (2.9 KB) - added by Rudolph 7 years ago.
Finally the correct patch, sorry for the noise.

Download all attachments as: .zip

Change History (12)

Changed 7 years ago by Rudolph

Removed a typo and altered the comments.

Changed 7 years ago by Rudolph

Removed a typo and altered the comments.

Changed 7 years ago by Rudolph

Removed a typo and altered the comments (sorry, previous patch did not change anything)

Changed 7 years ago by Rudolph

Finally the correct patch, sorry for the noise.

comment:1 Changed 7 years ago by ericholscher

  • milestone set to 1.0 maybe
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 7 years ago by jacob

  • milestone changed from 1.0 maybe to post-1.0
  • Triage Stage changed from Design decision needed to Accepted

comment:3 Changed 6 years ago by anonymous

  • milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:4 Changed 6 years ago by Rudolph

Latest patch still applies cleanly and all tests pass.

comment:5 Changed 4 years ago by lukeplant

  • Severity set to Normal
  • Type set to New feature

comment:6 Changed 4 years ago by julien

  • Easy pickings unset
  • Patch needs improvement set

The tests would need to be rewritten using unittests since this is now Django's preferred way.

comment:7 Changed 3 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:8 Changed 3 years ago by aaugustin

  • Keywords localflavorsplit added
  • Resolution set to invalid
  • Status changed from new to closed

django.contrib.localflavor is now deprecated — see https://docs.djangoproject.com/en/dev/ref/contrib/localflavor/

A repository was created for each localflavor at https://github.com/django/django-localflavor-? (Replace with the country code.)

If you're still interested in this ticket, could you create a pull request on that repository?

Sorry for not resolving this issue earlier, and thanks for your input!

Note: See TracTickets for help on using tickets.
Back to Top