Cannot use the same field to prepopulate multiple fields

[Fraser Nevett]

Take, for example, this ModelAdmin:

class ExampleAdmin(admin.ModelAdmin):
    prepopulated_fields = {
       "slug": ("name",),
       "full_slug": ("name", "category"),
       }

It results in the following Javascript being generated in the template:

    document.getElementById("id_full_slug").onchange = function() { this._changed = true; };
    
    document.getElementById("id_name").onkeyup = function() {
        var e = document.getElementById("id_full_slug");
        if (!e._changed) { e.value = URLify(document.getElementById("id_name").value + ' ' + document.getElementById("id_category").value, 50); }
    }
    
    document.getElementById("id_category").onkeyup = function() {
        var e = document.getElementById("id_full_slug");
        if (!e._changed) { e.value = URLify(document.getElementById("id_name").value + ' ' + document.getElementById("id_category").value, 50); }
    }
    

    document.getElementById("id_slug").onchange = function() { this._changed = true; };
    
    document.getElementById("id_name").onkeyup = function() {
        var e = document.getElementById("id_slug");
        if (!e._changed) { e.value = URLify(document.getElementById("id_name").value, 50); }
    }

The cause of the problem is the event listeners being attached by simply setting the onkeyup property. This means the second assignment overwrites the first one.

To attach multiple event listeners, the addEvent function defined in core.js should be used.

[Fraser Nevett]

Patch to use addEvent

[Rami Kassab]

Modified patch since the JS the first patch refers to has been moved...

[Rami Kassab]

Confirmed this minor bug. Currently, with 'name' being used to pre-populate two fields, 'slug' will be pre-populated while typing; however, 'full_slug' won't be pre-populated until the user tabs away from 'name'. If the user clicks on a different field instead of tabs, 'full_slug' will never be pre-populated with name. This patch fixes the issue; however, I had to attach a modified version since the location of the JS that the original patch modified has been moved to 'django/contrib/admin/templates/admin/prepopulated_fields_js.html'.

[James Bennett]

This is relatively minor and I think we can safely punt it in favor of more critical work.

[(none)]

Milestone post-1.0 deleted

[Carl Meyer]

This is a duplicate of #9264 - closing this one since Jacob marked the patch on #9264 RFC. I suspect both patches might get superseded by a jQuery-based reworking anyway, but I'll add a note on #9264 to check the patch here.