Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#7946 closed (fixed)

Object history should reuse existing date formats, instead of implementing itself

Reported by: garcia_marc Owned by: nobody
Component: Internationalization Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:


Django has some date formats in that can be defined in translations, and used anywhere. Different formats exists such as DATE_FORMAT, DATETIME_FORMAT, TIME_FORMAT...

Object history template is using another format, that actually is (or should be) the same as DATETIME_FORMAT, called DATE_WITH_TIME_FULL.

I think that if the format is the same, it should be defined once, or if it isn't the same, it should be added to to allow usage in user's code.

Attachments (1)

7946.diff (757 bytes) - added by garcia_marc 7 years ago.
patch for using existing format

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by garcia_marc

patch for using existing format

comment:1 Changed 7 years ago by programmerq

  • milestone set to 1.0
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

This makes sense to me, but I don't know if there was a good reason for doing it this way in the first place.

comment:2 Changed 7 years ago by ebruning

  • Has patch set

comment:3 Changed 7 years ago by jacob

  • Triage Stage changed from Design decision needed to Ready for checkin

comment:4 Changed 7 years ago by russellm

  • Resolution set to fixed
  • Status changed from new to closed

(In [8485]) Fixed #7946: Modified object history template to use a common date format. Thanks to Marc Garcia for the report and patch.

comment:5 Changed 4 years ago by jacob

  • milestone 1.0 deleted

Milestone 1.0 deleted

Note: See TracTickets for help on using tickets.
Back to Top