Context Navigation

← Previous Ticket
Next Ticket →

#7936 closed New feature (fixed)

Add Last-Modified header to feeds

Reported by:	Julian Bez	Owned by:	Claude Paroz <claude@…>
Component:	contrib.syndication	Version:	dev
Severity:	Normal	Keywords:	syndication last-modified
Cc:	tom@…, d1fffuz0r@…	Triage Stage:	Accepted
Has patch:	no	Needs documentation:	no
Needs tests:	no	Patch needs improvement:	yes
Easy pickings:	no	UI/UX:	no

Description

The patch adds a Last-Modified header to feeds generated by the syndication app.

We already have the latest date, so why not use it?

Works best with django.middleware.http.ConditionalGetMiddleware, which does the work of responding with 304 etc.

Attachments (2)

syndication-lastmodified.diff (813 bytes ) - added by Julian Bez 16 years ago.
syndication-lastmodified.2.diff (1.1 KB ) - added by Julian Bez 14 years ago.: Patch updated against 1.2.1

Download all attachments as: .zip

Change History (22)

by Julian Bez, 16 years ago

Attachment:	syndication-lastmodified.diff added

comment:1 by Julian Bez, 16 years ago

Status:	new → assigned
Triage Stage:	Unreviewed → Accepted

comment:2 by Julian Bez, 16 years ago

Component:	Contrib apps → RSS framework

comment:3 by anonymous, 16 years ago

milestone:	→ 1.0

comment:4 by James Bennett, 16 years ago

milestone:	1.0 → post-1.0

This is a minor feature and can safely be dealt with post-1.0.

comment:5 by Arthur Koziel, 16 years ago

Version:	SVN → 1.0

comment:6 by (none), 16 years ago

milestone:	post-1.0

Milestone post-1.0 deleted

comment:7 by Julian Bez, 16 years ago

Would be nice to know when post-1.0 is.

comment:8 by anonymous, 15 years ago

Version:	1.0 → 1.2-alpha

comment:9 by anonymous, 15 years ago

milestone:	→ 1.2

comment:10 by James Bennett, 15 years ago

milestone:	1.2

This is a feature request, and so it cannot go on the 1.2 milestone; 1.2 is feature frozen.

comment:11 by Julian Bez, 14 years ago

Owner:	Julian Bez removed
Status:	assigned → new

by Julian Bez, 14 years ago

Attachment:	syndication-lastmodified.2.diff added

Patch updated against 1.2.1

comment:12 by Matthias Kestenholz, 14 years ago

Needs tests:	set

Tests are missing.

comment:13 by Luke Plant, 14 years ago

Severity:	→ Normal
Type:	→ New feature

comment:14 by Tom Christie, 14 years ago

Cc:	tom@… added
Easy pickings:	unset

comment:15 by Aymeric Augustin, 13 years ago

Patch needs improvement:	set
UI/UX:	unset

Patch no longer applies.

comment:16 by Roman Gladkov, 12 years ago

Cc:	d1fffuz0r@… added
Has patch:	unset
Needs tests:	unset
Version:	1.2-alpha → master

https://github.com/django/django/pull/409

comment:17 by Claude Paroz <claude@…>, 12 years ago

Owner:	set to Claude Paroz <claude@…>
Resolution:	→ fixed
Status:	new → closed

In 08d675a98f1ae1d27f7e1946125ed5316c576802:

Fixed #7936 -- Added Last-Modified header to feeds

Thanks julianb for the report and the initial patch, and Roman
Gladkov for working on tests.

comment:18 by Markus Holtermann, 12 years ago

Hi, There is another ticket requesting to back-port this feature to 1.4 (or even 1.3). Closed that one as duplicate #20087.

comment:19 by Ramiro Morales <cramm0@…>, 11 years ago

In 62dfd79f8b4a1f7e702809cc21ce262f19da0f5b:

Fixed #21165 -- Fix test for syndication feed timestamp field on Windows.

Thanks Michael Manfre for the report, Raphaël Barrois for the patch and
Claude Paroz, Aymeric Augustin for the reviews.

Refs #7936.

comment:20 by Ramiro Morales <ramiro@…>, 11 years ago

In 5252885494079cf28a337644a87e61b19340f09c:

[1.6.x] Fixed #21165 -- Fix test for syndication feed timestamp field on Windows.