Opened 8 years ago

Closed 4 years ago

Last modified 3 years ago

#7936 closed New feature (fixed)

Add Last-Modified header to feeds

Reported by: Julian Bez Owned by: Claude Paroz <claude@…>
Component: contrib.syndication Version: master
Severity: Normal Keywords: syndication last-modified
Cc: tom@…, d1fffuz0r@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

The patch adds a Last-Modified header to feeds generated by the syndication app.

We already have the latest date, so why not use it?

Works best with django.middleware.http.ConditionalGetMiddleware, which does the work of responding with 304 etc.

Attachments (2)

syndication-lastmodified.diff (813 bytes) - added by Julian Bez 8 years ago.
syndication-lastmodified.2.diff (1.1 KB) - added by Julian Bez 6 years ago.
Patch updated against 1.2.1

Download all attachments as: .zip

Change History (22)

Changed 8 years ago by Julian Bez

comment:1 Changed 8 years ago by Julian Bez

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset
Status: newassigned
Triage Stage: UnreviewedAccepted

comment:2 Changed 8 years ago by Julian Bez

Component: Contrib appsRSS framework

comment:3 Changed 8 years ago by anonymous

milestone: 1.0

comment:4 Changed 8 years ago by James Bennett

milestone: 1.0post-1.0

This is a minor feature and can safely be dealt with post-1.0.

comment:5 Changed 8 years ago by Arthur Koziel

Version: SVN1.0

comment:6 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:7 Changed 7 years ago by Julian Bez

Would be nice to know when post-1.0 is.

comment:8 Changed 7 years ago by anonymous

Version: 1.01.2-alpha

comment:9 Changed 7 years ago by anonymous

milestone: 1.2

comment:10 Changed 7 years ago by James Bennett

milestone: 1.2

This is a feature request, and so it cannot go on the 1.2 milestone; 1.2 is feature frozen.

comment:11 Changed 6 years ago by Julian Bez

Owner: Julian Bez deleted
Status: assignednew

Changed 6 years ago by Julian Bez

Patch updated against 1.2.1

comment:12 Changed 6 years ago by Matthias Kestenholz

Needs tests: set

Tests are missing.

comment:13 Changed 5 years ago by Luke Plant

Severity: Normal
Type: New feature

comment:14 Changed 5 years ago by Tom Christie

Cc: tom@… added
Easy pickings: unset

comment:15 Changed 5 years ago by Aymeric Augustin

Patch needs improvement: set
UI/UX: unset

Patch no longer applies.

comment:16 Changed 4 years ago by Roman Gladkov

Cc: d1fffuz0r@… added
Has patch: unset
Needs tests: unset
Version: 1.2-alphamaster

comment:17 Changed 4 years ago by Claude Paroz <claude@…>

Owner: set to Claude Paroz <claude@…>
Resolution: fixed
Status: newclosed

In 08d675a98f1ae1d27f7e1946125ed5316c576802:

Fixed #7936 -- Added Last-Modified header to feeds

Thanks julianb for the report and the initial patch, and Roman
Gladkov for working on tests.

comment:18 Changed 4 years ago by Markus Holtermann

Hi, There is another ticket requesting to back-port this feature to 1.4 (or even 1.3). Closed that one as duplicate #20087.

comment:19 Changed 3 years ago by Ramiro Morales <cramm0@…>

In 62dfd79f8b4a1f7e702809cc21ce262f19da0f5b:

Fixed #21165 -- Fix test for syndication feed timestamp field on Windows.

Thanks Michael Manfre for the report, Raphaël Barrois for the patch and
Claude Paroz, Aymeric Augustin for the reviews.

Refs #7936.

comment:20 Changed 3 years ago by Ramiro Morales <ramiro@…>

In 5252885494079cf28a337644a87e61b19340f09c:

[1.6.x] Fixed #21165 -- Fix test for syndication feed timestamp field on Windows.

Thanks Michael Manfre for the report, Raphaël Barrois for the patch and
Claude Paroz, Aymeric Augustin for the reviews.

Refs #7936

62dfd79f8b from master.

Note: See TracTickets for help on using tickets.
Back to Top