#7936 closed New feature (fixed)

Add Last-Modified header to feeds

Reported by:	julianb	Owned by:	Claude Paroz <claude@…>
Component:	contrib.syndication	Version:	master
Severity:	Normal	Keywords:	syndication last-modified
Cc:	tom@…, d1fffuz0r@…	Triage Stage:	Accepted
Has patch:	no	Needs documentation:	no
Needs tests:	no	Patch needs improvement:	yes
Easy pickings:	no	UI/UX:	no

Description

The patch adds a Last-Modified header to feeds generated by the syndication app.

We already have the latest date, so why not use it?

Works best with django.middleware.http.ConditionalGetMiddleware, which does the work of responding with 304 etc.

Change History (22)

Changed 6 years ago by julianb

Attachment syndication-lastmodified.diff added

comment:1 Changed 6 years ago by julianb

Needs documentation unset
Needs tests unset
Patch needs improvement unset
Status changed from new to assigned
Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 6 years ago by julianb

Component changed from Contrib apps to RSS framework

comment:3 Changed 6 years ago by anonymous

milestone set to 1.0

comment:4 Changed 6 years ago by ubernostrum

milestone changed from 1.0 to post-1.0

This is a minor feature and can safely be dealt with post-1.0.

comment:5 Changed 6 years ago by arthurk

Version changed from SVN to 1.0

comment:6 Changed 5 years ago by anonymous

milestone post-1.0 deleted

Milestone post-1.0 deleted

comment:7 Changed 5 years ago by julianb

Would be nice to know when post-1.0 is.

comment:8 Changed 4 years ago by anonymous

Version changed from 1.0 to 1.2-alpha

comment:9 Changed 4 years ago by anonymous

milestone set to 1.2

comment:10 Changed 4 years ago by ubernostrum

milestone 1.2 deleted

This is a feature request, and so it cannot go on the 1.2 milestone; 1.2 is feature frozen.

comment:11 Changed 4 years ago by julianb

Owner julianb deleted
Status changed from assigned to new

Changed 4 years ago by julianb

Attachment syndication-lastmodified.2.diff added

Patch updated against 1.2.1

comment:12 Changed 4 years ago by mk

Needs tests set

Tests are missing.

comment:13 Changed 3 years ago by lukeplant

Severity set to Normal
Type set to New feature

comment:14 Changed 3 years ago by tomchristie

Cc tom@… added
Easy pickings unset

comment:15 Changed 2 years ago by aaugustin

Patch needs improvement set
UI/UX unset

Patch no longer applies.

comment:16 Changed 19 months ago by d1ffuz0r

Cc d1fffuz0r@… added
Has patch unset
Needs tests unset
Version changed from 1.2-alpha to master

https://github.com/django/django/pull/409

comment:17 Changed 19 months ago by Claude Paroz <claude@…>

Owner set to Claude Paroz <claude@…>
Resolution set to fixed
Status changed from new to closed

In 08d675a98f1ae1d27f7e1946125ed5316c576802:

Fixed #7936 -- Added Last-Modified header to feeds

Thanks julianb for the report and the initial patch, and Roman
Gladkov for working on tests.

comment:18 Changed 13 months ago by MarkusH

Hi, There is another ticket requesting to back-port this feature to 1.4 (or even 1.3). Closed that one as duplicate #20087.

comment:19 Changed 7 months ago by Ramiro Morales <cramm0@…>

In 62dfd79f8b4a1f7e702809cc21ce262f19da0f5b:

Fixed #21165 -- Fix test for syndication feed timestamp field on Windows.

Thanks Michael Manfre for the report, Raphaël Barrois for the patch and
Claude Paroz, Aymeric Augustin for the reviews.

Refs #7936.

comment:20 Changed 6 months ago by Ramiro Morales <ramiro@…>

In 5252885494079cf28a337644a87e61b19340f09c:

[1.6.x] Fixed #21165 -- Fix test for syndication feed timestamp field on Windows.