Opened 15 years ago
Closed 8 years ago
#7923 closed New feature (fixed)
Add links when using raw_id_fields in admin
Reported by: | Julian Bez | Owned by: | Hugo Osvaldo Barrera |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | admin raw_id_fields |
Cc: | bthomas@…, hugo@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
When using raw_id_fields in the admin application you get a field with the id and a link for looking up an id.
Already 'selected' objects are written next to the field for your information, but are not linked.
The patch improves that. You can browse through the objects now.
Attachments (6)
Change History (29)
Changed 15 years ago by
Attachment: | admin-rawid-link.diff added |
---|
comment:1 Changed 15 years ago by
milestone: | 1.0 beta |
---|
comment:2 Changed 15 years ago by
milestone: | → post-1.0 |
---|---|
Triage Stage: | Unreviewed → Design decision needed |
comment:3 Changed 15 years ago by
Cc: | bthomas@… added |
---|
Changed 15 years ago by
Attachment: | patchtest.diff added |
---|
comment:4 Changed 15 years ago by
comment:5 Changed 15 years ago by
Status: | new → assigned |
---|
I think I followed the behavior of the magnifying glass. That is always there and results in a 404 if the object does not have an admin page. This should then be fixed, too.
comment:7 Changed 14 years ago by
Cc: | hv@… added |
---|
comment:8 Changed 14 years ago by
I've updated the code to recent trunk at http://github.com/mrts/django/tree/ticket7923 . One thing that needs to be resolved is whether the link should open in a pop-up. I personally prefer the current behaviour, but a pop-up would be more consistent with how the magnifying glass and + works.
comment:9 Changed 14 years ago by
milestone: | → 1.2 |
---|---|
Triage Stage: | Design decision needed → Accepted |
Changed 14 years ago by
Attachment: | ticket7923-3.patch added |
---|
Fix a copy-paste from test output that hardcoded admin media prefix.
comment:10 Changed 14 years ago by
The patch has been merged into the patch attached to #7028 as both issues are tightly related. Will not update the patch here any more.
comment:11 Changed 14 years ago by
Cc: | hv@… removed |
---|---|
Resolution: | → duplicate |
Status: | assigned → closed |
See #7028
comment:12 Changed 13 years ago by
Here's a snippet that adds links to ManyToManyField too: http://djangosnippets.org/snippets/2217/
comment:14 Changed 8 years ago by
Easy pickings: | unset |
---|---|
Severity: | → Normal |
Type: | → Uncategorized |
UI/UX: | unset |
Some of the latest patches from #7028 don't include this functionality any more - aside from the fact that the other issue has stagnated for a year now.
Can we reopen this, since it's simpler to implement alone? I'd be willing to work on it myself.
comment:16 Changed 8 years ago by
Cc: | hugo@… added |
---|
comment:17 Changed 8 years ago by
Has patch: | unset |
---|---|
Resolution: | duplicate |
Status: | closed → new |
Type: | Uncategorized → New feature |
Seems fine to me. What about if the user doesn't have the "change" permission though? In that case we'll be outputting a link that leads to a "Permission Denied" page. It's not immediately obvious to me if there's a way to address that.
comment:18 Changed 8 years ago by
We can check if the user has change permissions before rendering the link.
We already do this to show the magnifying glass, I just need to dig into it a bit. I'll get back on this ASAP.
comment:19 Changed 8 years ago by
We already do this to show the magnifying glass, I just need to dig into it a bit. I'll get back on this ASAP.
Scrub that, the magnifying glass to select a related model is also shown if there are no permissions. There seems to be no clean way of avoiding a link to a 403 page - but it *is* consistent with the rest of the widget's behaviour (it's also a bit debatable if it's right to exclude the link or not).
I'm attaching an updated patch (GitHub is down ATM). It also uses the current admin site, rather than the default admin instance (which I noticed right away on my test app which uses several admin instances).
Changed 8 years ago by
Attachment: | 0001-Add-links-when-using-raw_id_fields-in-admin.patch added |
---|
Patch updated to apply on current master
comment:20 Changed 8 years ago by
Owner: | changed from Julian Bez to Hugo Osvaldo Barrera |
---|---|
Status: | new → assigned |
comment:21 Changed 8 years ago by
Has patch: | set |
---|
Submitted a PR: https://github.com/django/django/pull/6054
comment:22 Changed 8 years ago by
Patch needs improvement: | set |
---|
Left comments for improvement on the pull request.
comment:23 Changed 8 years ago by
Patch needs improvement: | unset |
---|
Are the linked objects guaranteed to have an admin page? Looks like this patch assumes that they have one.