Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#7885 closed (fixed)

Prevent duplicates in fields and fieldsets declarations

Reported by: julien Owned by: wamberg
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The patch I did for #4305 was only fixing the issue for 'fieldsets', so I closed it in favour of this ticket, which also takes care of 'fields'.

The attached patch prevents the multiple declarations of fields in the 'fields' and 'fieldsets' attributes. This is to prevent some confusion, having a same field multiple times in a form not making much sense and potentially leading to some unexpected behaviour when saving. Patch also contains tests.

Attachments (2)

duplicate_field_declarations.diff (2.5 KB) - added by julien 7 years ago.
Patch + tests
duplicate_field_declarations_2.diff (2.4 KB) - added by wamberg 7 years ago.
Added python2.3 support to previous patch.

Download all attachments as: .zip

Change History (7)

Changed 7 years ago by julien

Patch + tests

comment:1 Changed 7 years ago by jamesturk

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 7 years ago by wamberg

  • Owner changed from nobody to wamberg

Changed 7 years ago by wamberg

Added python2.3 support to previous patch.

comment:3 Changed 7 years ago by wamberg

  • Triage Stage changed from Accepted to Ready for checkin

Ready for checkin with Malcolm's blessing at DC Sprint

comment:4 Changed 7 years ago by brosner

  • Resolution set to fixed
  • Status changed from new to closed

(In [8173]) Fixed #7885 -- Prevent duplicates in fields and fieldsets declarations. Thanks julien and wamberg for the patches.

comment:5 Changed 4 years ago by jacob

  • milestone 1.0 beta deleted

Milestone 1.0 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top