Code

Opened 6 years ago

Closed 4 years ago

Last modified 3 years ago

#7876 closed (fixed)

Improve template error messages to include expected end tag

Reported by: joerg@… Owned by: mk
Component: Template system Version: master
Severity: Keywords:
Cc: mk@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

If there's a mismatch for block tags, the exception raised currently is only of limited help to trace it down.
It would be nice if it can be changed e.g. to

Invalid block tag: 'endblock', expected: 'endwidth'

and maybe even print the line of the start block.

Attachments (1)

7876.patch (1.1 KB) - added by mk 6 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by adrian

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Summary changed from Improve template diagnostic to Improve template error messages to include expected end tag
  • Triage Stage changed from Unreviewed to Accepted

This would indeed be a great feature.

Changed 6 years ago by mk

comment:2 Changed 6 years ago by mk

  • Cc mk@… added
  • Has patch set
  • Owner changed from nobody to mk
  • Status changed from new to assigned

comment:3 Changed 5 years ago by mk

  • Triage Stage changed from Accepted to Ready for checkin

Patch still applies to current trunk, and works as expected.

comment:4 Changed 4 years ago by mk

  • milestone set to 1.2

comment:5 Changed 4 years ago by jezdez

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [12460]) Fixed #7876 - Improved template error message to include expected end tag. Thanks to Matthias Kestenholz for the initial patch.

comment:6 Changed 3 years ago by jacob

  • milestone 1.2 deleted

Milestone 1.2 deleted

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.