Opened 8 years ago

Closed 7 years ago

Last modified 5 years ago

#7876 closed (fixed)

Improve template error messages to include expected end tag

Reported by: joerg@… Owned by: Matthias Kestenholz
Component: Template system Version: master
Severity: Keywords:
Cc: mk@… Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

If there's a mismatch for block tags, the exception raised currently is only of limited help to trace it down.
It would be nice if it can be changed e.g. to

Invalid block tag: 'endblock', expected: 'endwidth'

and maybe even print the line of the start block.

Attachments (1)

7876.patch (1.1 KB) - added by Matthias Kestenholz 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 8 years ago by Adrian Holovaty

Summary: Improve template diagnosticImprove template error messages to include expected end tag
Triage Stage: UnreviewedAccepted

This would indeed be a great feature.

Changed 8 years ago by Matthias Kestenholz

Attachment: 7876.patch added

comment:2 Changed 8 years ago by Matthias Kestenholz

Cc: mk@… added
Has patch: set
Owner: changed from nobody to Matthias Kestenholz
Status: newassigned

comment:3 Changed 7 years ago by Matthias Kestenholz

Triage Stage: AcceptedReady for checkin

Patch still applies to current trunk, and works as expected.

comment:4 Changed 7 years ago by Matthias Kestenholz

milestone: 1.2

comment:5 Changed 7 years ago by Jannis Leidel

Resolution: fixed
Status: assignedclosed

(In [12460]) Fixed #7876 - Improved template error message to include expected end tag. Thanks to Matthias Kestenholz for the initial patch.

comment:6 Changed 5 years ago by Jacob

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top