./manage.py reset fails if app does not define models

[miracle2k]

./manage.py reset fails with an obscure IndexError if an app does not define models.

There seems to be no strong reason why it should fail though, and in fact the problem is a line in core/management/sql.py that doesn't seem to have any effect at all anyway (see patch).

[James Bennett]

Since reset is intended to drop and re-create tables belonging to the models defined in an application, shouldn't resetting a model-less application be an error? Silently passing on this situation seems like a bad idea, since that may well mask deeper errors (e.g., if someone's scripting management commands, this could hide bugs in their script).

[miracle2k]

Well, lack of models in an application that you expect to be there seems like a pretty big error, that surely should surface easily at some other point. And while I am unable to check check right now, I think I remember that most of the other commands involving models don't complain either, so I'd be in line with that behaviour.

I was in fact scripting management when I stumbled on this, iterating over INSTALLED_APPS and calling call_command'ing "reset". I'm able to workaround that problem of course by checking with get_app(emptyOK=True) and get_models() myself, so it's not that big a deal.

[Russell Keith-Magee]

(In [8401]) Fixes #7845: Removed a piece of stale code that was causing ./manage.py reset to fail with apps that don't have any models. Thanks to miracle2k for the report and patch.

[Jacob]

Milestone 1.0 deleted