#7811 closed (fixed)
The contrib.admindocs templates are still part of the contrib.admin templates directory
Reported by: | Remco Wendt | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Keywords: | ||
Cc: | Triage Stage: | Accepted | |
Has patch: | no | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
In revision 7947 of newforms-admin the contrib.admindocs templates are still part of the contrib.admin templates directory. The templates should be moved to their own templates directory in contrib.admindocs.
Change History (9)
comment:1 by , 16 years ago
milestone: | 1.0 alpha → 1.0 beta |
---|---|
Triage Stage: | Unreviewed → Design decision needed |
comment:2 by , 16 years ago
Version: | newforms-admin → SVN |
---|
comment:3 by , 16 years ago
Owner: | changed from | to
---|
comment:4 by , 16 years ago
comment:5 by , 16 years ago
Owner: | changed from | to
---|
To further expand on my previous comment:
The only change necessary to resolve this ticket is to move files to contrib/admindocs/templates/admin_doc, subject to the requirement that the user add django.contrib.admindocs to his installed apps list.
The change described above does not completely resolve the separation of admin and admindocs. The admin_doc templates depend on admin/base_site.html.
So, two decisions are needed: one on the requirement on the user, and another about whether the separation implied by moving files is indeed separate enough.
comment:6 by , 16 years ago
ebruning,
Thanks very much for looking into this throughly. I would hope users understand that an application should likely always be in INSTALLED_APPS
. This should be noted in some documentation just be sure. Your second point is a good one, but I think that it is fine to require the admin application. At this point the admin docs are very embedded in the admin anyways that is fine to see that dependancy go in that direction. So basically this change would make things work as Django should be expected to be used.
comment:7 by , 16 years ago
Triage Stage: | Design decision needed → Accepted |
---|
comment:8 by , 16 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Moving the admin_docs template directory to contrib.admindocs requires the addition of django.contrib.admindocs to the installed apps list.