Opened 7 years ago

Closed 7 years ago

Last modified 4 years ago

#7811 closed (fixed)

The contrib.admindocs templates are still part of the contrib.admin templates directory

Reported by: shanx Owned by: nobody
Component: contrib.admin Version: master
Severity: Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

In revision 7947 of newforms-admin the contrib.admindocs templates are still part of the contrib.admin templates directory. The templates should be moved to their own templates directory in contrib.admindocs.

Change History (9)

comment:1 Changed 7 years ago by brosner

  • milestone changed from 1.0 alpha to 1.0 beta
  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 7 years ago by Alex

  • Version changed from newforms-admin to SVN

comment:3 Changed 7 years ago by anonymous

  • Owner changed from nobody to ebruning

comment:4 Changed 7 years ago by ebruning

Moving the admin_docs template directory to contrib.admindocs requires the addition of django.contrib.admindocs to the installed apps list.

comment:5 Changed 7 years ago by ebruning

  • Owner changed from ebruning to nobody

To further expand on my previous comment:

The only change necessary to resolve this ticket is to move files to contrib/admindocs/templates/admin_doc, subject to the requirement that the user add django.contrib.admindocs to his installed apps list.

The change described above does not completely resolve the separation of admin and admindocs. The admin_doc templates depend on admin/base_site.html.

So, two decisions are needed: one on the requirement on the user, and another about whether the separation implied by moving files is indeed separate enough.

comment:6 Changed 7 years ago by brosner

ebruning,

Thanks very much for looking into this throughly. I would hope users understand that an application should likely always be in INSTALLED_APPS. This should be noted in some documentation just be sure. Your second point is a good one, but I think that it is fine to require the admin application. At this point the admin docs are very embedded in the admin anyways that is fine to see that dependancy go in that direction. So basically this change would make things work as Django should be expected to be used.

comment:7 Changed 7 years ago by jacob

  • Triage Stage changed from Design decision needed to Accepted

comment:8 Changed 7 years ago by jacob

  • Resolution set to fixed
  • Status changed from new to closed

(In [8264]) Fixed #7811: moved admindocs templates into admindocs/templates. This is slightly backwards-incompatible in that if you're using the admindocs you'll need to add 'django.contrib.admindocs' to INSTALLED_APPS.

comment:9 Changed 4 years ago by jacob

  • milestone 1.0 beta deleted

Milestone 1.0 beta deleted

Note: See TracTickets for help on using tickets.
Back to Top